|
Revert of Mojo: Eliminate duplicate C API symbols (patchset #3 id:80001 of https://codereview.chromium.org/2044023004/ )
Reason for revert:
tentative revert due to linker errors. this doesn't make sense. nothing makes sense. RIP sanity
Original issue's description:
> Mojo: Eliminate duplicate C API symbols
>
> This gets rid of the duplicate definitions of public
> Mojo C API symbols, instead making mojo/public/c/system
> the singular source of these definitions. This allows
> targets to be linked against mojo/public libraries
> without requiring any additional EDK dependencies at
> build time.
>
> To facilitate this the EDK uses the same set of API
> thunks as the public library, and the public library
> exposes a special embedder API (distinct from the DSO
> MojoSetSystemThunks call used by the native app loader)
> for setting these thunks. The MojoSetSystemThunks API
> is moved to a module which is only linked directly into
> app DSOs.
>
> Because mojo/public/c/system and mojo/edk/system are
> now both components, and because there are no longer
> redundant exports between the two, it's now safe for
> targets to depend on either one or both of them as
> needed without encountering duplicate definitions.
>
> Also some opportunistic cleanup of Mojo build rules.
>
> BUG= 612500
>
> Committed: https://crrev.com/464e306a82ead839f02f1930a684400228b72495
> Cr-Commit-Position: refs/heads/master@{#398605}
TBR=jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 612500
Committed: https://crrev.com/e8e242161954d86ce8e064f8a6515bc818d5b600
Cr-Commit-Position: refs/heads/master@{#398614}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+829 lines, -719 lines) |
Patch |
 |
M |
mojo/edk/embedder/BUILD.gn
|
View
|
|
4 chunks |
+10 lines, -2 lines |
0 comments
|
Download
|
 |
M |
mojo/edk/embedder/embedder.cc
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
D |
mojo/edk/embedder/entrypoints.h
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
M |
mojo/edk/embedder/entrypoints.cc
|
View
|
|
5 chunks |
+98 lines, -147 lines |
0 comments
|
Download
|
 |
M |
mojo/edk/system/BUILD.gn
|
View
|
|
2 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
 |
M |
mojo/mojo.gyp
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
mojo/mojo_base.gyp
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mojo/mojo_edk.gyp
|
View
|
|
3 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
 |
M |
mojo/mojo_edk_nacl.gyp
|
View
|
|
3 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
mojo/mojo_edk_tests.gyp
|
View
|
|
5 chunks |
+4 lines, -11 lines |
0 comments
|
Download
|
 |
M |
mojo/mojo_public.gyp
|
View
|
|
5 chunks |
+41 lines, -11 lines |
0 comments
|
Download
|
 |
A |
mojo/mojo_variables.gypi
|
View
|
|
1 chunk |
+50 lines, -0 lines |
0 comments
|
Download
|
 |
M |
mojo/public/c/system/BUILD.gn
|
View
|
|
2 chunks |
+30 lines, -19 lines |
0 comments
|
Download
|
 |
D |
mojo/public/c/system/set_thunks_for_app.cc
|
View
|
|
1 chunk |
+0 lines, -20 lines |
0 comments
|
Download
|
 |
M |
mojo/public/c/system/system_export.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
D |
mojo/public/c/system/thunks.h
|
View
|
|
1 chunk |
+0 lines, -174 lines |
0 comments
|
Download
|
 |
D |
mojo/public/c/system/thunks.cc
|
View
|
|
1 chunk |
+0 lines, -284 lines |
0 comments
|
Download
|
 |
M |
mojo/public/mojo_application.gni
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A |
mojo/public/platform/native/BUILD.gn
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
A |
mojo/public/platform/native/system_thunks.h
|
View
|
|
1 chunk |
+213 lines, -0 lines |
0 comments
|
Download
|
 |
A |
mojo/public/platform/native/system_thunks.cc
|
View
|
|
1 chunk |
+287 lines, -0 lines |
0 comments
|
Download
|
 |
A |
mojo/public/platform/native/thunk_export.h
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
M |
services/shell/runner/host/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
services/shell/runner/host/native_application_support.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/gfx/gfx.gyp
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
Total messages: 7 (2 generated)
|