Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2047793002: tracing: ensure __metadata events are always added to the trace (Closed)

Created:
4 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing: ensure __metadata events are always added to the trace This is a temporary workaround to deal with the fact that some metadata events, such as TRACE_EVENT_CLOCK_SYNC_*, are not added to the trace if the category filter disables the default categories (-*). A proper long-term fix is being discussd in the attached bug. BUG=618054 Committed: https://crrev.com/d5fbde04754b74a75c0d75878f275e37791118b1 Cr-Commit-Position: refs/heads/master@{#398398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/trace_event/trace_event_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Primiano Tucci (use gerrit)
4 years, 6 months ago (2016-06-07 20:43:12 UTC) #3
oystein (OOO til 10th of July)
lgtm
4 years, 6 months ago (2016-06-07 20:46:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047793002/1
4 years, 6 months ago (2016-06-07 21:03:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 22:16:55 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 22:18:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5fbde04754b74a75c0d75878f275e37791118b1
Cr-Commit-Position: refs/heads/master@{#398398}

Powered by Google App Engine
This is Rietveld 408576698