Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2047753002: Add hack to enable multilogin. (Closed)

Created:
4 years, 6 months ago by M-A Ruel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Vadim Sh.
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add hack to enable multilogin. Makes the whole thing more coherent. R=stip@chromium.org BUG=chromium:613770 Committed: https://github.com/luci/luci-py/commit/8e01c592d1c01f15d8539ddbe3c5823375348075

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -44 lines) Patch
M appengine/components/components/ereporter2/templates/base.html View 1 chunk +2 lines, -11 lines 0 comments Download
M appengine/components/components/template.py View 1 chunk +5 lines, -2 lines 0 comments Download
M appengine/isolate/acl.py View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/isolate/templates/base.html View 1 chunk +2 lines, -11 lines 0 comments Download
M appengine/isolate/templates/root.html View 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/swarming/handlers_frontend.py View 1 chunk +0 lines, -1 line 1 comment Download
M appengine/swarming/server/acl.py View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/swarming/templates/base.html View 1 chunk +2 lines, -11 lines 2 comments Download
M appengine/swarming/templates/root.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
M-A Ruel
Live on staging
4 years, 6 months ago (2016-06-07 18:00:44 UTC) #1
ghost stip (do not use)
lgtm https://chromiumcodereview.appspot.com/2047753002/diff/1/appengine/swarming/handlers_frontend.py File appengine/swarming/handlers_frontend.py (left): https://chromiumcodereview.appspot.com/2047753002/diff/1/appengine/swarming/handlers_frontend.py#oldcode646 appengine/swarming/handlers_frontend.py:646: 'now': utils.utcnow(), aw https://chromiumcodereview.appspot.com/2047753002/diff/1/appengine/swarming/templates/base.html File appengine/swarming/templates/base.html (left): https://chromiumcodereview.appspot.com/2047753002/diff/1/appengine/swarming/templates/base.html#oldcode35 ...
4 years, 6 months ago (2016-06-07 23:04:25 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/2047753002/diff/1/appengine/swarming/templates/base.html File appengine/swarming/templates/base.html (left): https://chromiumcodereview.appspot.com/2047753002/diff/1/appengine/swarming/templates/base.html#oldcode35 appengine/swarming/templates/base.html:35: {{now|datetimeformat}}<br> On 2016/06/07 23:04:25, stip wrote: > you don't ...
4 years, 6 months ago (2016-06-07 23:31:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047753002/1
4 years, 6 months ago (2016-06-07 23:31:23 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 23:34:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/8e01c592d1c01f15d8539ddbe3c5823375348075

Powered by Google App Engine
This is Rietveld 408576698