Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 2047723002: Check the hint table exists before using. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Check the hint table exists before using. It's possible for the hint table to not exist event though we have a hint key in the object database. If the table does not exist then return false from CheckHIntTables(). BUG=pdfium:512 Committed: https://pdfium.googlesource.com/pdfium/+/0687e76dc259c678b3f29a6608331f07ffd8f1e2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-07 16:54:44 UTC) #2
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-07 17:07:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047723002/1
4 years, 6 months ago (2016-06-07 17:43:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/0687e76dc259c678b3f29a6608331f07ffd8f1e2
4 years, 6 months ago (2016-06-07 17:43:46 UTC) #7
Lei Zhang
4 years, 6 months ago (2016-06-08 01:40:53 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2047723002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/2047723002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:751: if (!pHintStreamRange)
In the bug, you mentioned this code infinite loops with the given test case. You
probably should add: m_docStatus = PDF_DATAAVAIL_ERROR - same treatment as if
the "H" key does not exist on line 739.

Powered by Google App Engine
This is Rietveld 408576698