Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

Issue 2047713002: [NTP Snippets] Cache images in a LevelDB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@protodb_get
Patch Set: add TODOs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/proto/ntp_snippets.proto ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
index eef5186abb3d98b596272b5d394e0bae48e2dbfb..c4cb425177768d3dab3b222c9f3ad5ad3a289e1c 100644
--- a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
@@ -11,6 +11,7 @@
#include "base/threading/thread_task_runner_handle.h"
#include "base/values.h"
#include "components/browser_sync/browser/profile_sync_service.h"
+#include "components/image_fetcher/image_decoder.h"
#include "components/image_fetcher/image_fetcher.h"
#include "components/keyed_service/ios/browser_state_dependency_manager.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
@@ -109,6 +110,8 @@ IOSChromeNTPSnippetsServiceFactory::BuildServiceInstanceFor(
base::SequencedWorkerPool::GetSequenceToken(),
base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
+ // TODO(treib,markusheintz): Inject an image_fetcher::ImageDecoder once that's
+ // implemented on iOS. crbug.com/609127
return base::WrapUnique(new ntp_snippets::NTPSnippetsService(
false /* enabled */, chrome_browser_state->GetPrefs(), sync_service,
suggestions_service, GetApplicationContext()->GetApplicationLocale(),
@@ -118,6 +121,7 @@ IOSChromeNTPSnippetsServiceFactory::BuildServiceInstanceFor(
GetChannel() == version_info::Channel::STABLE)),
base::WrapUnique(new ImageFetcherImpl(request_context.get(),
web::WebThread::GetBlockingPool())),
+ nullptr, /* image_decoder */
base::WrapUnique(
new ntp_snippets::NTPSnippetsDatabase(database_dir, task_runner))));
}
« no previous file with comments | « components/ntp_snippets/proto/ntp_snippets.proto ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698