Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 2047713002: [NTP Snippets] Cache images in a LevelDB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@protodb_get
Patch Set: add TODOs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_service.h
diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h
index fad27ab7e665d649fbdd8dccb2234d728026a086..1b1295c916572535b28a392b16255318f95e910a 100644
--- a/components/ntp_snippets/ntp_snippets_service.h
+++ b/components/ntp_snippets/ntp_snippets_service.h
@@ -17,6 +17,7 @@
#include "base/observer_list.h"
#include "base/scoped_observer.h"
#include "base/timer/timer.h"
+#include "components/image_fetcher/image_fetcher_delegate.h"
#include "components/keyed_service/core/keyed_service.h"
#include "components/ntp_snippets/ntp_snippet.h"
#include "components/ntp_snippets/ntp_snippets_fetcher.h"
@@ -28,6 +29,7 @@ class PrefRegistrySimple;
class PrefService;
namespace base {
+class RefCountedMemory;
class Value;
}
@@ -36,6 +38,7 @@ class Image;
}
namespace image_fetcher {
+class ImageDecoder;
class ImageFetcher;
}
@@ -65,7 +68,8 @@ class NTPSnippetsServiceObserver;
// Stores and vends fresh content data for the NTP.
class NTPSnippetsService : public KeyedService,
- public sync_driver::SyncServiceObserver {
+ public sync_driver::SyncServiceObserver,
+ public image_fetcher::ImageFetcherDelegate {
public:
using ImageFetchedCallback =
base::Callback<void(const std::string& snippet_id, const gfx::Image&)>;
@@ -82,6 +86,7 @@ class NTPSnippetsService : public KeyedService,
NTPSnippetsScheduler* scheduler,
std::unique_ptr<NTPSnippetsFetcher> snippets_fetcher,
std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher,
+ std::unique_ptr<image_fetcher::ImageDecoder> image_decoder,
std::unique_ptr<NTPSnippetsDatabase> database);
~NTPSnippetsService() override;
@@ -197,6 +202,10 @@ class NTPSnippetsService : public KeyedService,
// sync_driver::SyncServiceObserver implementation.
void OnStateChanged() override;
+ // image_fetcher::ImageFetcherDelegate implementation.
+ void OnImageDataFetched(const std::string& snippet_id,
+ const std::string& image_data) override;
+
// Callback for the NTPSnippetsDatabase.
void OnDatabaseLoaded(NTPSnippet::PtrVector snippets);
@@ -222,6 +231,17 @@ class NTPSnippetsService : public KeyedService,
void LoadingSnippetsFinished();
+ void OnSnippetImageFetchedFromDatabase(const std::string& snippet_id,
+ const ImageFetchedCallback& callback,
+ std::string data);
+
+ void OnSnippetImageDecoded(const std::string& snippet_id,
+ const ImageFetchedCallback& callback,
+ const gfx::Image& image);
+
+ void FetchSnippetImageFromNetwork(const std::string& snippet_id,
+ const ImageFetchedCallback& callback);
+
// Returns whether the service should be enabled or disable depending on its
// internal state and the state of its dependencies.
State GetStateForDependenciesStatus();
@@ -292,6 +312,7 @@ class NTPSnippetsService : public KeyedService,
base::OneShotTimer expiry_timer_;
std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher_;
+ std::unique_ptr<image_fetcher::ImageDecoder> image_decoder_;
// The database for persisting snippets.
std::unique_ptr<NTPSnippetsDatabase> database_;
« no previous file with comments | « components/ntp_snippets/ntp_snippets_database_unittest.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698