Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2047703003: Revert of Implement ui::ClipboardMus. (Closed)

Created:
4 years, 6 months ago by Elliot Glaysher
Modified:
4 years, 6 months ago
Reviewers:
brettw, sky, dcheng
CC:
dcheng, Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, rjkroege, tdresser+watch_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement ui::ClipboardMus. (patchset #23 id:440001 of https://codereview.chromium.org/2011833003/ ) Reason for revert: Broke Win x64 (dbg) due to size_t -> int conversion. Original issue's description: > Implement ui::ClipboardMus. > > This lets chrome in mash read and write from the mus server's clipboard. > > BUG=581460 > > Committed: https://crrev.com/bbc764eb7a7c1937d26f43f6087604ebc2d048ad > Cr-Commit-Position: refs/heads/master@{#398351} TBR=dcheng@chromium.org,brettw@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581460 Committed: https://crrev.com/940233aa4b7bd90b5423fa4daef22e35a81bed8d Cr-Commit-Position: refs/heads/master@{#398365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -781 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/mus/clipboard/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/clipboard/clipboard_impl.h View 1 chunk +5 lines, -3 lines 0 comments Download
M components/mus/clipboard/clipboard_impl.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M components/mus/clipboard/clipboard_unittest.cc View 6 chunks +16 lines, -15 lines 0 comments Download
M components/mus/public/interfaces/clipboard.mojom View 3 chunks +11 lines, -11 lines 0 comments Download
M mojo/common/common_type_converters.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/common/common_type_converters.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/clipboard/clipboard.h View 5 chunks +1 line, -19 lines 0 comments Download
M ui/base/clipboard/clipboard.cc View 4 chunks +21 lines, -41 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_aura.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 2 chunks +16 lines, -18 lines 0 comments Download
M ui/base/clipboard/clipboard_constants.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/clipboard/clipboard_test_template.h View 3 chunks +4 lines, -9 lines 0 comments Download
M ui/base/clipboard/clipboard_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/base/clipboard/custom_data_helper_linux.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/base/clipboard/custom_data_helper_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M ui/base/test/test_clipboard.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/base/test/test_clipboard_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/x/selection_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/x/selection_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 4 chunks +0 lines, -6 lines 0 comments Download
M ui/views/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/views/mus/clipboard_mus.h View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/views/mus/clipboard_mus.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D ui/views/mus/clipboard_unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elliot Glaysher
Created Revert of Implement ui::ClipboardMus.
4 years, 6 months ago (2016-06-07 19:21:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047703003/1
4 years, 6 months ago (2016-06-07 19:32:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 19:33:51 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 19:35:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/940233aa4b7bd90b5423fa4daef22e35a81bed8d
Cr-Commit-Position: refs/heads/master@{#398365}

Powered by Google App Engine
This is Rietveld 408576698