Store Origin Trials public key in browser prefs

chrome/common/origin_trials/origin_trial_key_manager.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_
 #define CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/strings/string_piece.h"
 
+class PrefRegistrySimple;
+
 // This class is instantiated on the main/ui thread, but its methods can be
 // accessed from any thread.
 class OriginTrialKeyManager {
  public:
   OriginTrialKeyManager();
   ~OriginTrialKeyManager();
 
   bool SetPublicKeyFromASCIIString(const std::string& ascii_public_key);
   base::StringPiece GetPublicKey() const;
 
+  static void RegisterPrefs(PrefRegistrySimple* registry);

[chasej, 2016/06/07 15:09:40]

I don't see a definition for this function. As per my comment in
browser_prefs.cc, this seems like the function I would expect called there.
Instead, the function provided in origin_trial_prefs.h/cc is used.

One of origin_trial_prefs.* or this method needs to be cleaned up, depending on
the resolution to my comment in browser_prefs.cc.

[iclelland, 2016/06/08 02:48:22]

This unused declaration shouldn't have made it to code review :) The method was
originally here, but chrome/common isn't allowed to depend on
chrome/components/prefs. That's why the method was moved into chrome/browser.

Declaration removed.

+
  private:
   std::string public_key_;
 
   DISALLOW_COPY_AND_ASSIGN(OriginTrialKeyManager);
 };
 
 #endif  // CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_