chrome/browser/prefs/origin_trial_prefs.cc - Issue 2047683002: Store Origin Trials public key in browser prefs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/origin_trial_prefs.cc

Issue 2047683002: Store Origin Trials public key in browser prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/prefs/origin_trial_prefs.h"

	6

	7 #include "base/values.h"

	8 #include "chrome/common/pref_names.h"

	9 #include "components/prefs/pref_registry_simple.h"

	10

	11 void RegisterOriginTrialPrefs(PrefRegistrySimple* registry) {

	12 registry->RegisterStringPref(prefs::kOriginTrialPublicKey,

	13 "fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU=");
	chasej 2016/06/07 15:09:40 I assume this value is the base64-encoded version I assume this value is the base64-encoded version of the default public key in OriginTrialKeyManager (kDefaultPublicKey)? If so, why do we need to store two copies of the same value? I think it would be better to just register an empty string as the default value here. Besides avoiding a copy, it also means that the default public key is defined in OriginTrialKeyManager, where it is most likely to be looked for/found. iclelland 2016/06/08 02:48:22 Yes, one copy is much better. Done. Show quoted text On 2016/06/07 15:09:40, chasej wrote: > I assume this value is the base64-encoded version of the default public key in > OriginTrialKeyManager (kDefaultPublicKey)? > > If so, why do we need to store two copies of the same value? I think it would be > better to just register an empty string as the default value here. Besides > avoiding a copy, it also means that the default public key is defined in > OriginTrialKeyManager, where it is most likely to be looked for/found. Yes, one copy is much better. Done.
	14 }

OLD	NEW