Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2047673003: S390: [debug] implement intuitive semantics for stepping over await call. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [debug] implement intuitive semantics for stepping over await call. Port 8d90210a1e68b141b1b2345b7b898f6920df3a3d R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG=v8:4483 LOG=N Committed: https://crrev.com/701f94876c7462d774957f1b0ebb8bb1083b108e Cr-Commit-Position: refs/heads/master@{#36801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M src/s390/builtins-s390.cc View 2 chunks +34 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-07 19:51:21 UTC) #1
JaideepBajwa
lgtm
4 years, 6 months ago (2016-06-07 19:54:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047673003/1
4 years, 6 months ago (2016-06-07 19:55:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 20:17:23 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 20:17:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/701f94876c7462d774957f1b0ebb8bb1083b108e
Cr-Commit-Position: refs/heads/master@{#36801}

Powered by Google App Engine
This is Rietveld 408576698