Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2047643004: Change the timer to record the actual drawing time (Closed)

Created:
4 years, 6 months ago by xidachen
Modified:
4 years, 6 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, haraken, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the timer to record the actual drawing time Currently in the BaseRenderingContext2D.cpp, we put the scoped timer at the very beginning of some API functions. But that includes timing for some early exits cases. This CL makes changes such that we do not record the time for the early exits cases BUG=612585 Committed: https://crrev.com/38a83802d7b2af4fc25bbb6d20490fda1cba7700 Cr-Commit-Position: refs/heads/master@{#398381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -61 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 6 chunks +62 lines, -61 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
xidachen
PTAL
4 years, 6 months ago (2016-06-07 14:40:23 UTC) #2
Justin Novosad
On 2016/06/07 14:40:23, xidachen wrote: > PTAL Summary: actal -> actual
4 years, 6 months ago (2016-06-07 15:14:36 UTC) #3
Justin Novosad
On 2016/06/07 15:14:36, Justin Novosad wrote: > On 2016/06/07 14:40:23, xidachen wrote: > > PTAL ...
4 years, 6 months ago (2016-06-07 15:15:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047643004/1
4 years, 6 months ago (2016-06-07 15:19:14 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/159494)
4 years, 6 months ago (2016-06-07 16:06:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047643004/1
4 years, 6 months ago (2016-06-07 17:50:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 21:36:32 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 21:37:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38a83802d7b2af4fc25bbb6d20490fda1cba7700
Cr-Commit-Position: refs/heads/master@{#398381}

Powered by Google App Engine
This is Rietveld 408576698