|
Revert of Remove base/move.h (patchset #4 id:60001 of https://codereview.chromium.org/2038273002/ )
Reason for revert:
This breaks the Windows build on the waterfall.
The error log is:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/202064/steps/compile%20%28with%20patch%29/logs/stdio
FAILED: obj/ash/mus/lib/shelf_layout_impl.obj
ninja -t msvc -e environment.x86 -- E:\b\build\slave\cache\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ash/mus/lib/shelf_layout_impl.obj.rsp /c ../../ash/mus/shelf_layout_impl.cc /Foobj/ash/mus/lib/shelf_layout_impl.obj /Fd"obj/ash/mus/lib_cc.pdb"
e:\b\build\slave\win\build\src\base\template_util.h(65): error C2718: 'ui::LatencyInfo': actual parameter with requested alignment of 8 won't be aligned
e:\b\build\slave\win\build\src\base\template_util.h(86): note: see reference to class template instantiation 'base::internal::IsAssignableImpl<Lvalue,Rvalue,false>' being compiled
with
[
Lvalue=ui::LatencyInfo &,
Rvalue=ui::LatencyInfo &&
]
e:\b\build\slave\win\build\src\base\template_util.h(103): note: see reference to class template instantiation 'base::is_assignable<ui::LatencyInfo &,ui::LatencyInfo &&>' being compiled
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\lib\template_util.h(58): note: see reference to class template instantiation 'base::is_move_assignable<T>' being compiled
with
[
T=ui::LatencyInfo
]
e:\b\build\slave\win\build\src\mojo\public\cpp\bindings\array.h(34): note: see reference to class template instantiation 'mojo::internal::IsMoveOnlyType<MojomType>' being compiled
with
[
MojomType=ui::LatencyInfo
]
e:\b\build\slave\win\build\src\out\debug\gen\cc\ipc\compositor_frame_metadata.mojom.h(121): note: see reference to class template instantiation 'mojo::Array<ui::LatencyInfo>' being compiled
Original issue's description:
> Remove base/move.h
>
> It's the same thing as DISALLOW_COPY_AND_ASSIGN now anyway.
>
> BUG= 566182
>
> Committed: https://crrev.com/bb5161ab7ad524a9bced788f8099e786946f3a44
> Cr-Commit-Position: refs/heads/master@{#398237}
TBR=thakis@chromium.org,yzshen@chromium.org,jam@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 566182
Committed: https://crrev.com/b2235ba11d576ccc47dd2edfa66c7747a10f8d75
Cr-Commit-Position: refs/heads/master@{#398239}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+161 lines, -101 lines) |
Patch |
|
M |
PRESUBMIT.py
|
View
|
|
2 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
base/base.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
base/files/file.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
base/memory/scoped_vector.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
A |
base/move.h
|
View
|
|
1 chunk |
+44 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/process/process.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
base/scoped_generic.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
base/values.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
base/win/scoped_handle.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/printing/pdf_to_emf_converter.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/common/media_galleries/picasa_types.h
|
View
|
|
3 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/nacl/browser/nacl_process_host.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/audio_input_debug_writer.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/child/scoped_web_callbacks.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
dbus/file_descriptor.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
extensions/renderer/api/display_source/wifi_display/wifi_display_media_packetizer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/capture/video/scoped_result_callback.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/edk/embedder/scoped_platform_handle.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/array.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/associated_interface_ptr.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/associated_interface_ptr_info.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/associated_interface_request.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/interface_ptr.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/interface_ptr_info.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/interface_request.h
|
View
|
|
3 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/lib/filter_chain.h
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/lib/template_util.h
|
View
|
|
2 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/map.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/strong_binding.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/struct_ptr.h
|
View
|
|
6 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/tests/container_test_util.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/bindings/wtf_array.h
|
View
|
|
4 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
mojo/public/cpp/system/handle.h
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/base/file_stream_context.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
remoting/base/typed_buffer.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
storage/browser/blob/scoped_file.h
|
View
|
|
4 chunks |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
styleguide/c++/c++11.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ui/gl/android/scoped_java_surface.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 7 (3 generated)
|