Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: remoting/client/jni/jni_pairing_secret_fetcher.h

Issue 2047613002: [Remoting Android] Move pairing secret fetcher to the network thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/jni/jni_client.cc ('k') | remoting/client/jni/jni_pairing_secret_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/jni_pairing_secret_fetcher.h
diff --git a/remoting/client/jni/jni_pairing_secret_fetcher.h b/remoting/client/jni/jni_pairing_secret_fetcher.h
index 6b240a90c47bcc3666a140d6d15eacea57bf5ad1..39f448dfeb98331092efd5e83e809dbbd4a9f0b1 100644
--- a/remoting/client/jni/jni_pairing_secret_fetcher.h
+++ b/remoting/client/jni/jni_pairing_secret_fetcher.h
@@ -14,8 +14,9 @@ namespace remoting {
class ChromotingJniRuntime;
class JniClient;
-// This class fetches the pairing secret on the UI thread. It must be deleted
-// on UI.
+// This class fetches the pairing secret on the UI thread. This should be
+// created on the UI thread but there after used and deleted on the network
+// thread.
class JniPairingSecretFetcher {
public:
JniPairingSecretFetcher(ChromotingJniRuntime* runtime,
@@ -23,21 +24,24 @@ class JniPairingSecretFetcher {
const std::string& host_id);
virtual ~JniPairingSecretFetcher();
- // Called on UI thread. Notifies the user interface that the user needs to
- // enter a PIN. The current authentication attempt is put on hold until
- // |callback| is invoked. |callback| will be run on the network thread.
+ // Notifies the user interface that the user needs to enter a PIN. The current
+ // authentication attempt is put on hold until |callback| is invoked.
void FetchSecret(bool pairable,
const protocol::SecretFetchedCallback& callback);
// Provides the user's PIN and resumes the host authentication attempt. Call
- // on the UI thread once the user has finished entering this PIN into the UI,
- // but only after the UI has been asked to provide a PIN (via FetchSecret()).
+ // once the user has finished entering this PIN into the UI, but only after
+ // the UI has been asked to provide a PIN (via FetchSecret()).
void ProvideSecret(const std::string& pin);
- // Get weak pointer to be used on the UI thread.
+ // Get weak pointer to be used on the network thread.
base::WeakPtr<JniPairingSecretFetcher> GetWeakPtr();
private:
+ static void FetchSecretOnUiThread(base::WeakPtr<JniClient> client,
+ const std::string& host_id,
+ bool pairable);
+
ChromotingJniRuntime* jni_runtime_;
base::WeakPtr<JniClient> jni_client_;
« no previous file with comments | « remoting/client/jni/jni_client.cc ('k') | remoting/client/jni/jni_pairing_secret_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698