Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2047573005: Implement cc::FilterOperations StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, ajuma, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement cc::FilterOperations StructTraits BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4af5eca9361ef3e4253d78e1655f895e5e290214 Cr-Commit-Position: refs/heads/master@{#398759}

Patch Set 1 #

Patch Set 2 : Plumb cc::FilterOperations to mus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -11 lines) Patch
M cc/ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + cc/ipc/filter_operations.mojom View 1 chunk +6 lines, -3 lines 0 comments Download
A cc/ipc/filter_operations.typemap View 1 chunk +9 lines, -0 lines 0 comments Download
A cc/ipc/filter_operations_struct_traits.h View 1 chunk +32 lines, -0 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M cc/ipc/traits_test_service.mojom View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/ipc/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/filter_operations.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/output/filter_operations.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/interfaces/quads.mojom View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Fady Samuel
+ajuma@ for cc OWNERs +tsepez@ for ipc
4 years, 6 months ago (2016-06-08 16:04:41 UTC) #3
ajuma
lgtm
4 years, 6 months ago (2016-06-08 16:52:24 UTC) #4
Fady Samuel
+sky@: I now plumb FilterOperations into Mus, addressing a few TODO(jamesr)s.
4 years, 6 months ago (2016-06-08 17:21:52 UTC) #6
sky
LGTM
4 years, 6 months ago (2016-06-08 17:27:26 UTC) #7
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-08 17:40:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047573005/20001
4 years, 6 months ago (2016-06-08 21:58:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 01:33:02 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 01:34:28 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4af5eca9361ef3e4253d78e1655f895e5e290214
Cr-Commit-Position: refs/heads/master@{#398759}

Powered by Google App Engine
This is Rietveld 408576698