Revert of Promises: Make PromiseSet operation monomorphic

Revert of Promises: Make PromiseSet operation monomorphic (patchset #1 id:1 of https://codereview.chromium.org/2025073002/ )

Reason for revert:
As a side effect of calling PromiseSet from
FulfillPromise, clears the deferred symbol and the
resolve/reject callback symbols. Although this
isn't strictly necessary, not doing this seems to
result in a leak as seen in --

https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10

Original issue's description:
> Promises: Make PromiseSet operation monomorphic
>
> The PromiseSet operation is called with two types of promises
> 1) A newly created promise object with no properties
> 2) Promise object with callbacks and other properties
>
> PromiseSet is called with the first type of promise (with no
> properties) from multiple call sites. PromiseSet is called with the
> second type of promise object only from FulfillPromise. Furthermore,
> this call only sets the value and status of the promise, the rest of
> the values are reset to UNDEFINED (which isn't necessary).
>
> This patch inlines the calls to set the value and status of the
> promise in FulfillPromise, instead of calling out to PromiseSet.
>
> This patch also reduces the number of symbol lookups, as we only set
> the value and status of the promise, and don't change the callback or
> deferred symbols.
>
> This patch results in a performance improvement of 2.8% over 5 runs in
> the bluebird benchmark.
>
> BUG=v8:5046
>
> Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
> Cr-Commit-Position: refs/heads/master@{#36688}

TBR=littledan@chromium.org,adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5046
Committed: https://crrev.com/9b606523b5e210f60c4260ee5f50a54e8f07adbd
Cr-Commit-Position: refs/heads/master@{#36766}

[gsathya, 2016-06-06 21:18:04]

Created Revert of Promises: Make PromiseSet operation monomorphic

[adamk, 2016-06-06 21:39:00]

lgtm

[gsathya, 2016-06-06 21:39:30]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 21:39:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047553002/1

[commit-bot: I haz the power, 2016-06-06 22:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 22:02:11]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-06-06 22:04:03]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2016-06-06 22:04:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047553002/1

[commit-bot: I haz the power, 2016-06-06 22:06:14]

Description was changed from

==========
Revert of Promises: Make PromiseSet operation monomorphic (patchset #1 id:1 of
https://codereview.chromium.org/2025073002/ )

Reason for revert:
As a side effect of calling PromiseSet from 
FulfillPromise, clears the deferred symbol and the 
resolve/reject callback symbols. Although this 
isn't strictly necessary, not doing this seems to 
result in a leak as seen in --

https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10

Original issue's description:
> Promises: Make PromiseSet operation monomorphic
> 
> The PromiseSet operation is called with two types of promises
> 1) A newly created promise object with no properties
> 2) Promise object with callbacks and other properties
> 
> PromiseSet is called with the first type of promise (with no
> properties) from multiple call sites. PromiseSet is called with the
> second type of promise object only from FulfillPromise. Furthermore,
> this call only sets the value and status of the promise, the rest of
> the values are reset to UNDEFINED (which isn't necessary).
> 
> This patch inlines the calls to set the value and status of the
> promise in FulfillPromise, instead of calling out to PromiseSet.
> 
> This patch also reduces the number of symbol lookups, as we only set
> the value and status of the promise, and don't change the callback or
> deferred symbols.
> 
> This patch results in a performance improvement of 2.8% over 5 runs in
> the bluebird benchmark.
> 
> BUG=v8:5046
> 
> Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
> Cr-Commit-Position: refs/heads/master@{#36688}

TBR=littledan@chromium.org,adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5046
==========

to

==========
Revert of Promises: Make PromiseSet operation monomorphic (patchset #1 id:1 of
https://codereview.chromium.org/2025073002/ )

Reason for revert:
As a side effect of calling PromiseSet from 
FulfillPromise, clears the deferred symbol and the 
resolve/reject callback symbols. Although this 
isn't strictly necessary, not doing this seems to 
result in a leak as seen in --

https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10

Original issue's description:
> Promises: Make PromiseSet operation monomorphic
> 
> The PromiseSet operation is called with two types of promises
> 1) A newly created promise object with no properties
> 2) Promise object with callbacks and other properties
> 
> PromiseSet is called with the first type of promise (with no
> properties) from multiple call sites. PromiseSet is called with the
> second type of promise object only from FulfillPromise. Furthermore,
> this call only sets the value and status of the promise, the rest of
> the values are reset to UNDEFINED (which isn't necessary).
> 
> This patch inlines the calls to set the value and status of the
> promise in FulfillPromise, instead of calling out to PromiseSet.
> 
> This patch also reduces the number of symbol lookups, as we only set
> the value and status of the promise, and don't change the callback or
> deferred symbols.
> 
> This patch results in a performance improvement of 2.8% over 5 runs in
> the bluebird benchmark.
> 
> BUG=v8:5046
> 
> Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
> Cr-Commit-Position: refs/heads/master@{#36688}

TBR=littledan@chromium.org,adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5046
==========

[commit-bot: I haz the power, 2016-06-06 22:06:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-06 22:06:56]

Description was changed from

==========
Revert of Promises: Make PromiseSet operation monomorphic (patchset #1 id:1 of
https://codereview.chromium.org/2025073002/ )

Reason for revert:
As a side effect of calling PromiseSet from 
FulfillPromise, clears the deferred symbol and the 
resolve/reject callback symbols. Although this 
isn't strictly necessary, not doing this seems to 
result in a leak as seen in --

https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10

Original issue's description:
> Promises: Make PromiseSet operation monomorphic
> 
> The PromiseSet operation is called with two types of promises
> 1) A newly created promise object with no properties
> 2) Promise object with callbacks and other properties
> 
> PromiseSet is called with the first type of promise (with no
> properties) from multiple call sites. PromiseSet is called with the
> second type of promise object only from FulfillPromise. Furthermore,
> this call only sets the value and status of the promise, the rest of
> the values are reset to UNDEFINED (which isn't necessary).
> 
> This patch inlines the calls to set the value and status of the
> promise in FulfillPromise, instead of calling out to PromiseSet.
> 
> This patch also reduces the number of symbol lookups, as we only set
> the value and status of the promise, and don't change the callback or
> deferred symbols.
> 
> This patch results in a performance improvement of 2.8% over 5 runs in
> the bluebird benchmark.
> 
> BUG=v8:5046
> 
> Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
> Cr-Commit-Position: refs/heads/master@{#36688}

TBR=littledan@chromium.org,adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5046
==========

to

==========
Revert of Promises: Make PromiseSet operation monomorphic (patchset #1 id:1 of
https://codereview.chromium.org/2025073002/ )

Reason for revert:
As a side effect of calling PromiseSet from
FulfillPromise, clears the deferred symbol and the
resolve/reject callback symbols. Although this
isn't strictly necessary, not doing this seems to
result in a leak as seen in --

https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10

Original issue's description:
> Promises: Make PromiseSet operation monomorphic
>
> The PromiseSet operation is called with two types of promises
> 1) A newly created promise object with no properties
> 2) Promise object with callbacks and other properties
>
> PromiseSet is called with the first type of promise (with no
> properties) from multiple call sites. PromiseSet is called with the
> second type of promise object only from FulfillPromise. Furthermore,
> this call only sets the value and status of the promise, the rest of
> the values are reset to UNDEFINED (which isn't necessary).
>
> This patch inlines the calls to set the value and status of the
> promise in FulfillPromise, instead of calling out to PromiseSet.
>
> This patch also reduces the number of symbol lookups, as we only set
> the value and status of the promise, and don't change the callback or
> deferred symbols.
>
> This patch results in a performance improvement of 2.8% over 5 runs in
> the bluebird benchmark.
>
> BUG=v8:5046
>
> Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5
> Cr-Commit-Position: refs/heads/master@{#36688}

TBR=littledan@chromium.org,adamk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5046

Committed: https://crrev.com/9b606523b5e210f60c4260ee5f50a54e8f07adbd
Cr-Commit-Position: refs/heads/master@{#36766}
==========

[commit-bot: I haz the power, 2016-06-06 22:06:56]

Patchset 1 (id:??) landed as
https://crrev.com/9b606523b5e210f60c4260ee5f50a54e8f07adbd
Cr-Commit-Position: refs/heads/master@{#36766}