base/trace_event/trace_config_unittest.cc - Issue 2047533002: [tracing] Add browser test for background memory tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_config_unittest.cc

Issue 2047533002: [tracing] Add browser test for background memory tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set_whitelist

Patch Set: Remove useless watch event. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_config_unittest.cc

diff --git a/base/trace_event/trace_config_unittest.cc b/base/trace_event/trace_config_unittest.cc

index b6503f5e907e2c539cf487205801046e661f8e66..b0a53f5a95ff3176989e8a054e33034ccfeefafc 100644

--- a/base/trace_event/trace_config_unittest.cc

+++ b/base/trace_event/trace_config_unittest.cc

@@ -587,7 +587,8 @@ TEST(TraceConfigTest, TraceConfigFromMemoryConfigString) {

tc1.memory_dump_config_.heap_profiler_options.breakdown_threshold_bytes);

std::string tc_str2 =

- TraceConfigMemoryTestUtil::GetTraceConfig_BackgroundTrigger();

+ TraceConfigMemoryTestUtil::GetTraceConfig_BackgroundTrigger(

+ 1 /* period_ms */);

TraceConfig tc2(tc_str2);

EXPECT_EQ(tc_str2, tc2.ToString());

EXPECT_TRUE(tc2.IsCategoryGroupEnabled(MemoryDumpManager::kTraceCategory));

« no previous file with comments | « base/trace_event/trace_config_memory_test_util.h ('k') | chrome/test/base/tracing.h » ('j') | no next file with comments »