base/trace_event/trace_config_memory_test_util.h - Issue 2047533002: [tracing] Add browser test for background memory tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_config_memory_test_util.h

Issue 2047533002: [tracing] Add browser test for background memory tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@set_whitelist

Patch Set: Remove single proc tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_dump_manager_unittest.cc ('K') | « base/trace_event/memory_dump_manager_unittest.cc ('k') | base/trace_event/trace_config_unittest.cc » ('j') | chrome/test/base/tracing.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/trace_config_memory_test_util.h

diff --git a/base/trace_event/trace_config_memory_test_util.h b/base/trace_event/trace_config_memory_test_util.h

index a7c9a3ac41df2d14116f56a7aa99842bbf1af01f..8245d6492afca70a2af30cc216f31a73433e87ac 100644

--- a/base/trace_event/trace_config_memory_test_util.h

+++ b/base/trace_event/trace_config_memory_test_util.h

@@ -72,7 +72,7 @@ class TraceConfigMemoryTestUtil {

"}", MemoryDumpManager::kTraceCategory);

}

- static std::string GetTraceConfig_BackgroundTrigger() {

+ static std::string GetTraceConfig_BackgroundTrigger(int period) {

Primiano Tucci (use gerrit) 2016/06/15 14:19:57 maybe s/period/period_ms/

ssid 2016/06/15 17:50:30 Done.

return StringPrintf(

"{"

"\"enable_argument_filter\":false,"

@@ -85,12 +85,12 @@ class TraceConfigMemoryTestUtil {

"\"triggers\":["

"{"

"\"mode\":\"background\","

- "\"periodic_interval_ms\":1"

+ "\"periodic_interval_ms\":%d"

"}"

"]"

"},"

"\"record_mode\":\"record-until-full\""

- "}", MemoryDumpManager::kTraceCategory);

+ "}", MemoryDumpManager::kTraceCategory, period);

}

};