Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2047523002: Supertype checking cleanup. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index 9054cabe99869f5ada4ffebaf905bd9675017c72..d74e92556dc052cd46a05a82d54d74cd78e05994 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -986,12 +986,10 @@ class BestPracticesVerifier extends RecursiveAstVisitor<Object> {
if (element == null) {
return false;
}
- if (element.type == type) {
- return true;
- }
ClassElement typeElement = type.element;
- return element.allSupertypes
- .any((InterfaceType t) => t.element == typeElement);
+ return element == typeElement ||
+ element.allSupertypes
+ .any((InterfaceType t) => t.element == typeElement);
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698