chrome/browser/profiles/profiles_state.cc - Issue 2047483003: Add fallback behavior if the last used profile cannot initialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profiles_state.cc

Issue 2047483003: Add fallback behavior if the last used profile cannot initialize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bug-614753-fix

Patch Set: Respond to comments, copy base/test/* from CL 2061593002 again. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/test_file_util.h ('K') | « chrome/browser/profiles/profiles_state.h ('k') | chrome/browser/ui/profile_error_dialog.h » ('j') | chrome/browser/ui/startup/startup_browser_creator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profiles_state.cc

diff --git a/chrome/browser/profiles/profiles_state.cc b/chrome/browser/profiles/profiles_state.cc

index e3acad3245bcec2402530d7f62da5aba6b7dbbf0..3cfa03ca464408ba6dd74ad84cc9d0210f1580ad 100644

--- a/chrome/browser/profiles/profiles_state.cc

+++ b/chrome/browser/profiles/profiles_state.cc

@@ -215,9 +215,9 @@ bool SetActiveProfileToGuestIfLocked() {

bool has_entry =

g_browser_process->profile_manager()->GetProfileAttributesStorage().

GetProfileAttributesWithPath(active_profile_path, &entry);

- DCHECK(has_entry);

- if (!entry->IsSigninRequired())

+ // |has_entry| may be false if a profile is specified on the command line.

+ if (has_entry && !entry->IsSigninRequired())

return false;

SetLastUsedProfile(guest_path.BaseName().MaybeAsASCII());