Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2047473002: Revert of Specify direct dependency of //components/crash on kasko_features.h (Closed)

Created:
4 years, 6 months ago by Sébastien Marchand
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sadrul, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, darin-cc_chromium.org, kalyank, syzygy-team_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Specify direct dependency of //components/crash on kasko_features.h (patchset #1 id:1 of https://codereview.chromium.org/2038473002/ ) Reason for revert: It's breaking the official win-asan builder (https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/268) Original issue's description: > Specify direct dependency of //components/crash on kasko_features.h > > //components/crash/content/app has a public dependency on the generated > header kasko_features.h. However, the GYP and GN files specify this > dependency only transitively via a dependency on //third_party/kasko > (which //components/crash/content/app does not actually depend on). This > CL changes the dependency to be directly on > //third_party/kasko:kasko_features as a speculative fix for the build > failures listed in crbug.com/611319. Note that in any case this change > is correct (whether it ends up resolving the flaky build failures or no). > > BUG=611319 > TBR=pmonette > > Committed: https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc > Cr-Commit-Position: refs/heads/master@{#397390} TBR=mark@chromium.org,pmonette@chromium.org,blundell@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=611319 Committed: https://crrev.com/0983a7c38cb33066a2ad57f6da0dc21cd7376493 Cr-Commit-Position: refs/heads/master@{#398063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/crash.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Sébastien Marchand
Created Revert of Specify direct dependency of //components/crash on kasko_features.h
4 years, 6 months ago (2016-06-06 16:47:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047473002/1
4 years, 6 months ago (2016-06-06 16:47:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 18:10:43 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 18:12:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0983a7c38cb33066a2ad57f6da0dc21cd7376493
Cr-Commit-Position: refs/heads/master@{#398063}

Powered by Google App Engine
This is Rietveld 408576698