DescriptionRevert of Specify direct dependency of //components/crash on kasko_features.h (patchset #1 id:1 of https://codereview.chromium.org/2038473002/ )
Reason for revert:
It's breaking the official win-asan builder (https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/268)
Original issue's description:
> Specify direct dependency of //components/crash on kasko_features.h
>
> //components/crash/content/app has a public dependency on the generated
> header kasko_features.h. However, the GYP and GN files specify this
> dependency only transitively via a dependency on //third_party/kasko
> (which //components/crash/content/app does not actually depend on). This
> CL changes the dependency to be directly on
> //third_party/kasko:kasko_features as a speculative fix for the build
> failures listed in crbug.com/611319. Note that in any case this change
> is correct (whether it ends up resolving the flaky build failures or no).
>
> BUG=611319
> TBR=pmonette
>
> Committed: https://crrev.com/d507af25f7281161a3eb0d44a0deef057e46c8dc
> Cr-Commit-Position: refs/heads/master@{#397390}
TBR=mark@chromium.org,pmonette@chromium.org,blundell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=611319
Committed: https://crrev.com/0983a7c38cb33066a2ad57f6da0dc21cd7376493
Cr-Commit-Position: refs/heads/master@{#398063}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|