tools/android/loading/test_utils.py - Issue 2047463002: Set tracing categories explicitly in Clovis and Sandwich

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/test_utils.py

Issue 2047463002: Set tracing categories explicitly in Clovis and Sandwich (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/test_utils.py

diff --git a/tools/android/loading/test_utils.py b/tools/android/loading/test_utils.py

index cb2fd2ecff23266ef86758a859a6d150a31b02bc..86303f952f351ff19088a8bdc0bb6a51109acdec 100644

--- a/tools/android/loading/test_utils.py

+++ b/tools/android/loading/test_utils.py

@@ -4,6 +4,7 @@

"""Common utilities used in unit tests, within this directory."""

+import clovis_constants

import dependency_graph

import devtools_monitor

import loading_trace

@@ -140,7 +141,8 @@ def LoadingTraceFromEvents(requests, page_events=None, trace_events=None):

request = FakeRequestTrack(requests)

page_event_track = FakePageTrack(page_events if page_events else [])

if trace_events is not None:

- tracing_track = tracing.TracingTrack(None)

+ tracing_track = tracing.TracingTrack(None,

+ clovis_constants.DEFAULT_CATEGORIES)

tracing_track.Handle('Tracing.dataCollected',

{'params': {'value': [e for e in trace_events]}})

else:

« no previous file with comments | « tools/android/loading/sandwich_runner.py ('k') | tools/android/loading/trace_test/webserver_test.py » ('j') | no next file with comments »