Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2047433005: Remove unused code from aot optimizer. (Closed)

Created:
4 years, 6 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused code from aot optimizer. FLAG_polymophic_with_deopt is always false when generating precompiled code, so this function is not needed. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c88a8a648ca4f4fbd7d1d5c7cee04cd328c03118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M runtime/vm/aot_optimizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 6 months ago (2016-06-07 18:02:43 UTC) #2
rmacnak
lgtm
4 years, 6 months ago (2016-06-07 20:01:09 UTC) #3
Florian Schneider
4 years, 6 months ago (2016-06-07 20:30:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c88a8a648ca4f4fbd7d1d5c7cee04cd328c03118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698