base/synchronization/condition_variable.h - Issue 2047433004: content: Add heartbeat trace for CategorizedWorkerPool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/condition_variable.h

Issue 2047433004: content: Add heartbeat trace for CategorizedWorkerPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/condition_variable.h

diff --git a/base/synchronization/condition_variable.h b/base/synchronization/condition_variable.h

index ebf90d249a33954bfaca75d3634523a58f112aef..b00f2bf025383cd616f0981965cd74964bb6707b 100644

--- a/base/synchronization/condition_variable.h

+++ b/base/synchronization/condition_variable.h

@@ -93,7 +93,8 @@ class BASE_EXPORT ConditionVariable {

// Wait() releases the caller's critical section atomically as it starts to

// sleep, and the reacquires it when it is signaled.

void Wait();

- void TimedWait(const TimeDelta& max_time);

+ // TimedWait() returns true on timeout, otherwise returns false.

+ bool TimedWait(const TimeDelta& max_time);

robliao 2016/06/07 15:40:30 Add a unit test to check this.

// Broadcast() revives all waiting threads.

void Broadcast();

« no previous file with comments | « no previous file | base/synchronization/condition_variable_posix.cc » ('j') | base/synchronization/condition_variable_win.cc » ('J')