third_party/WebKit/LayoutTests/media/autoplay/autoplay-document-move.html - Issue 2047433003: Update autoplay settings when moving media elements between documents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/autoplay/autoplay-document-move.html

Issue 2047433003: Update autoplay settings when moving media elements between documents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments, added layout tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/VirtualTestSuites ('k') | third_party/WebKit/LayoutTests/media/autoplay/autoplay-document-move-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Moving media element to other document to bypass autoplay</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="../media-file.js"></script>

	6 <body>

	7 <script>

	8 console.warn("dummy log entry to avoid an empty -expected.txt in virtual/");

	9

	10 test(function() {
	mlamouri (slow - plz ping) 2016/06/07 19:59:01 You should use a async_test here. You should use a async_test here. Zhiqiang Zhang (Slow) 2016/06/08 16:11:56 Done. Show quoted text On 2016/06/07 19:59:01, Mounir Lamouri (slow) wrote: > You should use a async_test here. Done.
	11 var v = document.implementation.createHTMLDocument().createElement('video');

	12 v.src = findMediaFile('video', '../content/test');

	13 document.body.appendChild(v);

	14 assert_true(document.querySelector('video') != null, 'video was not moved to document');

	15 assert_true(v.paused, 'video should be paused in initial state');

	16 v.play().then(
	mlamouri (slow - plz ping) 2016/06/07 19:59:01 You will have to use t.test_func_done() to wrap th You will have to use t.test_func_done() to wrap the "function(e) {" here. Zhiqiang Zhang (Slow) 2016/06/08 16:11:56 Done. Show quoted text On 2016/06/07 19:59:01, Mounir Lamouri (slow) wrote: > You will have to use t.test_func_done() to wrap the "function(e) {" here. Done.
	17 function(e) {

	18 console.warn("video starts playing");

	19 },

	20 function(e) {

	21 console.warn("caught expected exception");
	mlamouri (slow - plz ping) 2016/06/07 19:59:02 I think it's wrong to do console.warn() on testhar I think it's wrong to do console.warn() on testharness.js tests and assume that it will show and the file comparison will make the test pass or fail. You should have reall assert_. Maybe you could use window.internals to check if the flag is on/off? I know it makes things a bit less nice but I think it's slightly better :) Zhiqiang Zhang (Slow)* 2016/06/08 16:11:56 Done. Show quoted text On 2016/06/07 19:59:02, Mounir Lamouri (slow) wrote: > I think it's wrong to do console.warn() on testharness.js tests and assume that > it will show and the file comparison will make the test pass or fail. You should > have reall assert_*. Maybe you could use window.internals to check if the flag > is on/off? I know it makes things a bit less nice but I think it's slightly > better :) Done.
	22 });

	23 }, 'Test that video should not play without user gesture after moving to anoth er document');

	24 </script>

	25 </body>

OLD	NEW