Oilpan: Move AnimatableValue's hierarchy to oilpan's heap

Source/core/animation/KeyframeEffectModel.h

Index: Source/core/animation/KeyframeEffectModel.h
diff --git a/Source/core/animation/KeyframeEffectModel.h b/Source/core/animation/KeyframeEffectModel.h
index e22831ec109b5b5e11e37b63d43eb17536f4420e..f41e23f606d8bb565b5dc91535d457b21e440e5f 100644
--- a/Source/core/animation/KeyframeEffectModel.h
+++ b/Source/core/animation/KeyframeEffectModel.h
@@ -73,14 +73,15 @@ public:
     PassRefPtrWillBeRawPtr<Keyframe> clone() const { return adoptRefWillBeNoop(new Keyframe(*this)); }
     PassRefPtrWillBeRawPtr<Keyframe> cloneWithOffset(double offset) const;
 
-    void trace(Visitor*) { }
+    void trace(Visitor*);
+
 private:
     Keyframe();
     Keyframe(const Keyframe&);
     double m_offset;
     AnimationEffect::CompositeOperation m_composite;
     RefPtr<TimingFunction> m_easing;
-    typedef HashMap<CSSPropertyID, RefPtr<AnimatableValue> > PropertyValueMap;
+    typedef WillBeHeapHashMap<CSSPropertyID, RefPtrWillBeMember<AnimatableValue> > PropertyValueMap;
     PropertyValueMap m_propertyValues;
 };
 
@@ -121,12 +122,18 @@ public:
         const AnimatableValue* value() const { return m_value.get(); }
         AnimationEffect::CompositeOperation composite() const { return m_composite; }
         PassOwnPtr<PropertySpecificKeyframe> cloneWithOffset(double offset) const;

[Mads Ager (chromium), 2014/03/21 13:49:30]

Where is this PassOwnPtr consumed? Are you tracing the resulting OwnPtr? If this
is allocated with new we should move it to the heap?

+
+        void trace(Visitor* visitor)
+        {
+            visitor->trace(m_value);
+        }
+
     private:
         // Used by cloneWithOffset().
-        PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, PassRefPtr<AnimatableValue>, CompositeOperation);
+        PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, PassRefPtrWillBeRawPtr<AnimatableValue>, CompositeOperation);
         double m_offset;
         RefPtr<TimingFunction> m_easing;
-        RefPtr<AnimatableValue> m_value;
+        RefPtrWillBeMember<AnimatableValue> m_value;
         AnimationEffect::CompositeOperation m_composite;
     };