Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: Source/core/animation/AnimatableValueTestHelperTest.cpp

Issue 204743002: Oilpan: Move AnimatableValue's hierarchy to oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimatableValueTestHelper.cpp ('k') | Source/core/animation/AnimatableVisibility.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimatableValueTestHelperTest.cpp
diff --git a/Source/core/animation/AnimatableValueTestHelperTest.cpp b/Source/core/animation/AnimatableValueTestHelperTest.cpp
index d7f98ca3d0aaa2c06d6a99e14c6d375e3068be40..6ae5965005c6870e3fbf8f1e42013b6e05843fd8 100644
--- a/Source/core/animation/AnimatableValueTestHelperTest.cpp
+++ b/Source/core/animation/AnimatableValueTestHelperTest.cpp
@@ -50,14 +50,9 @@ namespace {
class AnimationAnimatableValueTestHelperTest : public ::testing::Test {
protected:
- ::std::string PrintToString(PassRefPtr<AnimatableValue> animValue)
+ ::std::string PrintToString(PassRefPtrWillBeRawPtr<AnimatableValue> animValue)
{
- return PrintToString(animValue.get());
- }
-
- ::std::string PrintToString(const AnimatableValue* animValue)
- {
- return ::testing::PrintToString(*animValue);
+ return ::testing::PrintToString(*animValue.get());
}
};
@@ -104,10 +99,10 @@ TEST_F(AnimationAnimatableValueTestHelperTest, PrintTo)
)));
EXPECT_THAT(
- PrintToString(AnimatableValue::neutralValue()),
+ PrintToString(const_cast<AnimatableValue*>(AnimatableValue::neutralValue())),
testing::StartsWith("AnimatableNeutral@"));
- Vector<RefPtr<AnimatableValue> > v1;
+ WillBeHeapVector<RefPtrWillBeMember<AnimatableValue> > v1;
v1.append(AnimatableLength::create(CSSPrimitiveValue::create(3, CSSPrimitiveValue::CSS_REMS).get()));
v1.append(AnimatableLength::create(CSSPrimitiveValue::create(4, CSSPrimitiveValue::CSS_PT).get()));
EXPECT_EQ(
« no previous file with comments | « Source/core/animation/AnimatableValueTestHelper.cpp ('k') | Source/core/animation/AnimatableVisibility.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698