Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: Source/core/animation/AnimatableUnknown.h

Issue 204743002: Oilpan: Move AnimatableValue's hierarchy to oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimatableTransform.cpp ('k') | Source/core/animation/AnimatableUnknownTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimatableUnknown.h
diff --git a/Source/core/animation/AnimatableUnknown.h b/Source/core/animation/AnimatableUnknown.h
index ec569258e062e4356d95892a8430caf81f44e5b8..c310416da607420aead451e3ae81e69b62ffd4ee 100644
--- a/Source/core/animation/AnimatableUnknown.h
+++ b/Source/core/animation/AnimatableUnknown.h
@@ -41,20 +41,25 @@ class AnimatableUnknown FINAL : public AnimatableValue {
public:
virtual ~AnimatableUnknown() { }
- static PassRefPtr<AnimatableUnknown> create(PassRefPtrWillBeRawPtr<CSSValue> value)
+ static PassRefPtrWillBeRawPtr<AnimatableUnknown> create(PassRefPtrWillBeRawPtr<CSSValue> value)
{
- return adoptRef(new AnimatableUnknown(value));
+ return adoptRefWillBeNoop(new AnimatableUnknown(value));
}
- static PassRefPtr<AnimatableUnknown> create(CSSValueID value)
+ static PassRefPtrWillBeRawPtr<AnimatableUnknown> create(CSSValueID value)
{
- return adoptRef(new AnimatableUnknown(cssValuePool().createIdentifierValue(value)));
+ return adoptRefWillBeNoop(new AnimatableUnknown(cssValuePool().createIdentifierValue(value)));
}
PassRefPtrWillBeRawPtr<CSSValue> toCSSValue() const { return m_value; }
CSSValueID toCSSValueID() const { return toCSSPrimitiveValue(m_value.get())->getValueID(); }
+ virtual void trace(Visitor* visitor) OVERRIDE
+ {
+ visitor->trace(m_value);
+ }
+
protected:
- virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue* value, double fraction) const OVERRIDE
+ virtual PassRefPtrWillBeRawPtr<AnimatableValue> interpolateTo(const AnimatableValue* value, double fraction) const OVERRIDE
{
return defaultInterpolateTo(this, value, fraction);
}
@@ -70,7 +75,7 @@ private:
virtual AnimatableType type() const OVERRIDE { return TypeUnknown; }
virtual bool equalTo(const AnimatableValue*) const OVERRIDE;
- const RefPtrWillBePersistent<CSSValue> m_value;
+ const RefPtrWillBeMember<CSSValue> m_value;
};
DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableUnknown, isUnknown());
« no previous file with comments | « Source/core/animation/AnimatableTransform.cpp ('k') | Source/core/animation/AnimatableUnknownTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698