Oilpan: Move AnimatableValue's hierarchy to oilpan's heap

Source/core/animation/AnimatableValueTestHelperTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 32 matching lines @@
 #include <sstream>
 #include <string>
 
 
 using namespace WebCore;
 
 namespace {
 
 class AnimationAnimatableValueTestHelperTest : public ::testing::Test {
 protected:
-    ::std::string PrintToString(PassRefPtr<AnimatableValue> animValue)
+    ::std::string PrintToString(PassRefPtrWillBeRawPtr<AnimatableValue> animValue)
     {
         return PrintToString(animValue.get());
     }
-
-    ::std::string PrintToString(const AnimatableValue* animValue)
-    {
-        return ::testing::PrintToString(*animValue);
-    }
 };
 
 TEST_F(AnimationAnimatableValueTestHelperTest, PrintTo)
 {
     EXPECT_THAT(
         PrintToString(AnimatableClipPathOperation::create(ShapeClipPathOperation::create(BasicShapeCircle::create().get()).get())),
         testing::StartsWith("AnimatableClipPathOperation")
         );
 
     EXPECT_EQ(
@@ skipping 25 matching lines @@
             )));
 
     EXPECT_EQ(
         ::std::string("AnimatableLengthSize(AnimatableLength(3rem), AnimatableLength(4pt))"),
         PrintToString(AnimatableLengthSize::create(
             AnimatableLength::create(CSSPrimitiveValue::create(3, CSSPrimitiveValue::CSS_REMS).get()),
             AnimatableLength::create(CSSPrimitiveValue::create(4, CSSPrimitiveValue::CSS_PT).get())
             )));
 
     EXPECT_THAT(
-        PrintToString(AnimatableValue::neutralValue()),
+        PrintToString(const_cast<AnimatableValue*>(AnimatableValue::neutralValue())),

[haraken, 2014/03/21 17:21:33]

I think you're talking about this const_cast, but I'd like to keep this
const_cast. This is a bit complicated.

If I keep both PrintToString(PassRefPtrWillBeRawPtr<AnimatableValue> animValue)
and PrintToString(const AnimatableValue* animValue), I hit a compile error when
calling PrintToString(foo()) where foo() returns a const raw pointer of a
sub-class of AnimatableValue, because the const raw pointer can be converted
into both RawPtr<AnimatableValue> and const AnimatableValue*.

I tried a couple of approaches to make it compilable in both oilpan build and
non-oilpan build, and the simplest approach I found was to remove
PrintToString(const AnimatableValue* animValue) and use const_cast here.

         testing::StartsWith("AnimatableNeutral@"));
 
-    Vector<RefPtr<AnimatableValue> > v1;
+    WillBeHeapVector<RefPtrWillBeMember<AnimatableValue> > v1;
     v1.append(AnimatableLength::create(CSSPrimitiveValue::create(3, CSSPrimitiveValue::CSS_REMS).get()));
     v1.append(AnimatableLength::create(CSSPrimitiveValue::create(4, CSSPrimitiveValue::CSS_PT).get()));
     EXPECT_EQ(
         ::std::string("AnimatableRepeatable(AnimatableLength(3rem), AnimatableLength(4pt))"),
         PrintToString(AnimatableRepeatable::create(v1)));
 
     RefPtr<SVGLength> length1cm = SVGLength::create(LengthModeOther);
     RefPtr<SVGLength> length2cm = SVGLength::create(LengthModeOther);
     length1cm->setValueAsString("1cm", ASSERT_NO_EXCEPTION);
     length2cm->setValueAsString("2cm", ASSERT_NO_EXCEPTION);
@@ skipping 36 matching lines @@
     EXPECT_EQ(
         ::std::string("AnimatableUnknown(none)"),
         PrintToString(AnimatableUnknown::create(CSSPrimitiveValue::createIdentifier(CSSValueNone).get())));
 
     EXPECT_EQ(
         ::std::string("AnimatableVisibility(VISIBLE)"),
         PrintToString(AnimatableVisibility::create(VISIBLE)));
 }
 
 } // namespace