Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2047413003: Disable 4 and 8 digit hex CSS colors (Closed)

Created:
4 years, 6 months ago by Rick Byers
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis, samli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable 4 and 8 digit hex CSS colors New compat concerns have been raised with 4 and 8 digit HEX color values in CSS. In particular, a targetSdk quirk needs to be added for Android WebView to avoid breaking Android apps. Demote this feature to "experimental" status until an owner can be found. BUG=618518, 76362 Committed: https://crrev.com/b7bc5783027ae86ff6eb6912d0a6112cda6a8814 Cr-Commit-Position: refs/heads/master@{#398789}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Color.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Rick Byers
Tim, PTAL
4 years, 6 months ago (2016-06-09 01:14:26 UTC) #3
Timothy Loh
On 2016/06/09 01:14:26, Rick Byers wrote: > Tim, PTAL lgtm
4 years, 6 months ago (2016-06-09 02:37:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047413003/20001
4 years, 6 months ago (2016-06-09 03:03:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 04:57:23 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 04:59:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7bc5783027ae86ff6eb6912d0a6112cda6a8814
Cr-Commit-Position: refs/heads/master@{#398789}

Powered by Google App Engine
This is Rietveld 408576698