Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 2047383003: MD User Manager: "Select an account" should just be a label not a menu entry (Closed)

Created:
4 years, 6 months ago by Moe
Modified:
4 years, 6 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-ui_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: "Select an account" should just be a label not a menu entry BUG=618151 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0adee993bc89a38802ee219e822292dcdf759d8a Cr-Commit-Position: refs/heads/master@{#398865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -32 lines) Patch
M chrome/browser/resources/md_user_manager/create_profile.html View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.js View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/test/data/webui/md_user_manager/create_profile_tests.js View 1 chunk +2 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Moe
Hi Demetrios, Please review this CL.
4 years, 6 months ago (2016-06-08 18:57:25 UTC) #3
dpapad
lgtm
4 years, 6 months ago (2016-06-08 23:07:28 UTC) #4
Moe
On 2016/06/08 23:07:28, dpapad wrote: > lgtm Thank you!
4 years, 6 months ago (2016-06-09 13:18:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047383003/1
4 years, 6 months ago (2016-06-09 13:19:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 13:48:04 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 13:49:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0adee993bc89a38802ee219e822292dcdf759d8a
Cr-Commit-Position: refs/heads/master@{#398865}

Powered by Google App Engine
This is Rietveld 408576698