Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: shell/android/android_handler.cc

Issue 2047333003: Roll base to ec59756cc1ad02cc835bcca10056a621c9eb346c. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/android/system/core_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/android_handler.cc
diff --git a/shell/android/android_handler.cc b/shell/android/android_handler.cc
index 5fec25f8710a3d8129dddddaaf7005f941de9346..a5a99eb4088929f9a185a770e24a791d30f3d95c 100644
--- a/shell/android/android_handler.cc
+++ b/shell/android/android_handler.cc
@@ -157,11 +157,11 @@ void AndroidHandler::ExtractApplication(base::FilePath* extracted_dir,
});
}
-jstring CreateTemporaryFile(JNIEnv* env,
- jclass jcaller,
- jstring j_directory,
- jstring j_basename,
- jstring j_extension) {
+ScopedJavaLocalRef<jstring> CreateTemporaryFile(JNIEnv* env,
+ jclass jcaller,
+ jstring j_directory,
+ jstring j_basename,
+ jstring j_extension) {
std::string basename(ConvertJavaStringToUTF8(env, j_basename));
std::string extension(ConvertJavaStringToUTF8(env, j_extension));
base::FilePath directory(ConvertJavaStringToUTF8(env, j_directory));
@@ -174,7 +174,7 @@ jstring CreateTemporaryFile(JNIEnv* env,
int fd = open(temporary_file.value().c_str(), O_CREAT | O_EXCL, 0600);
if (fd != -1) {
close(fd);
- return ConvertUTF8ToJavaString(env, temporary_file.value()).Release();
+ return ConvertUTF8ToJavaString(env, temporary_file.value());
}
}
}
« no previous file with comments | « mojo/android/system/core_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698