third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 2047333002: Pause autoplay muted video when unmuting if there's no user gesture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2047333002: Pause autoplay muted video when unmuting if there's no user gesture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autoplay-flag

Patch Set: Fixed accidental ws change Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/autoplay-muted.html ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index 7d4911c9ba09a966e826290e4a33b64ac047b271..08996bf1aaab6c4778221378800f71f15d426dfb 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -466,7 +466,7 @@ private:

// if isLockedPendingUserGesture() return true, this might return false if

// the requirement is currently overridden. This does not check if a user

// gesture is currently being processed.

- bool isGestureNeededForPlayback() const;

+ bool isGestureNeededForPlayback();

void setNetworkState(NetworkState);

@@ -582,6 +582,9 @@ private:

// Whether this element is in overlay fullscreen mode.

bool m_inOverlayFullscreenVideo : 1;

+ // Whether this element is autoplaying due to being muted.

+ bool m_isAutoplayingMuted : 1;

Member<AudioTrackList> m_audioTracks;

Member<VideoTrackList> m_videoTracks;

Member<TextTrackList> m_textTracks;