Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2312)

Unified Diff: chrome/browser/memory/tab_manager.h

Issue 2047283004: [TabManager] fixing comment at DiscardTabById function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory/tab_manager.h
diff --git a/chrome/browser/memory/tab_manager.h b/chrome/browser/memory/tab_manager.h
index c3f4a57f9cb4f3debb746dac4c70d01df048bdd9..0804ec0cf4043856c1bd89ef57ccabd130d9fe74 100644
--- a/chrome/browser/memory/tab_manager.h
+++ b/chrome/browser/memory/tab_manager.h
@@ -101,8 +101,8 @@ class TabManager : public TabStripModelObserver {
void DiscardTab();
// Discards a tab with the given unique ID. The tab still exists in the
- // tab-strip; clicking on it will reload it. Returns true if it successfully
- // found a tab and discarded it.
+ // tab-strip; clicking on it will reload it. Returns nullptr if it didn't find
+ // the tab or it can't be discared. Otherwise return a web_contents.
Anderson Silva 2016/06/08 15:57:48 In the implementation, the returned web_contens is
Georges Khalil 2016/06/09 13:50:52 Let's go with this: Returns null if the tab cannot
content::WebContents* DiscardTabById(int64_t target_web_contents_id);
// Log memory statistics for the running processes, then discards a tab.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698