Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2047283004:
[TabManager] fixing comment at DiscardTabById function. (Closed)
|
Created:
4 years, 6 months ago by Anderson Silva Modified:
4 years, 6 months ago Reviewers:
Georges Khalil CC:
chromium-reviews, chrisha Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[TabManager] fixing comment at DiscardTabById function.
BUG=618338
Committed: https://crrev.com/d4994a98367c4d08916fc77f69c62d68e4c3846b
Cr-Commit-Position: refs/heads/master@{#399538}
Patch Set 1 #
Total comments: 2
Patch Set 2 : comment fixed #Messages
Total messages: 16 (8 generated)
Description was changed from ========== [TabManager] fixing comment at DiscardTabById function. BUG=618338 ========== to ========== [TabManager] fixing comment at DiscardTabById function. BUG=618338 ==========
andersoncss@google.com changed reviewers: + georgesak@chromium.org
PTAL It's just a simple comments fixing. https://codereview.chromium.org/2047283004/diff/1/chrome/browser/memory/tab_m... File chrome/browser/memory/tab_manager.h (right): https://codereview.chromium.org/2047283004/diff/1/chrome/browser/memory/tab_m... chrome/browser/memory/tab_manager.h:105: // the tab or it can't be discared. Otherwise return a web_contents. In the implementation, the returned web_contens is named null_contents. What does it actually holds? Just some info in the TabStrip? Maybe we can put this info here in the comment.
lgtm with change to the comment. https://codereview.chromium.org/2047283004/diff/1/chrome/browser/memory/tab_m... File chrome/browser/memory/tab_manager.h (right): https://codereview.chromium.org/2047283004/diff/1/chrome/browser/memory/tab_m... chrome/browser/memory/tab_manager.h:105: // the tab or it can't be discared. Otherwise return a web_contents. On 2016/06/08 15:57:48, Anderson Silva wrote: > In the implementation, the returned web_contens is named null_contents. What > does it actually holds? Just some info in the TabStrip? Maybe we can put this > info here in the comment. Let's go with this: Returns null if the tab cannot be found or cannot be discarded. Otherwise returns the old web_contents that got discarded. This value is mostly useful during testing.
The CQ bit was checked by andersoncss@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from georgesak@chromium.org Link to the patchset: https://codereview.chromium.org/2047283004/#ps20001 (title: "comment fixed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047283004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by andersoncss@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047283004/20001
Message was sent while issue was closed.
Description was changed from ========== [TabManager] fixing comment at DiscardTabById function. BUG=618338 ========== to ========== [TabManager] fixing comment at DiscardTabById function. BUG=618338 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== [TabManager] fixing comment at DiscardTabById function. BUG=618338 ========== to ========== [TabManager] fixing comment at DiscardTabById function. BUG=618338 Committed: https://crrev.com/d4994a98367c4d08916fc77f69c62d68e4c3846b Cr-Commit-Position: refs/heads/master@{#399538} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d4994a98367c4d08916fc77f69c62d68e4c3846b Cr-Commit-Position: refs/heads/master@{#399538} |
