third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Animation expectation Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 7b7996ca542c27b32613429569ccd690bd5d2d9f..576c2d11e9c79c4fcc1724acc62eaec69ef3c5fe 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -2011,7 +2011,7 @@ void LayoutObject::styleWillChange(StyleDifference diff, const ComputedStyle& ne

// we need to dirty our stacking context's z-order list.

bool visibilityChanged = m_style->visibility() != newStyle.visibility()

|| m_style->zIndex() != newStyle.zIndex()

- || m_style->hasAutoZIndex() != newStyle.hasAutoZIndex();

+ || m_style->isStackingContext() != newStyle.isStackingContext();

if (visibilityChanged) {

document().setAnnotatedRegionsDirty(true);

if (AXObjectCache* cache = document().existingAXObjectCache())