Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1924 matching lines...) Expand 10 before | Expand all | Expand 10 after
1935 setShouldDoFullPaintInvalidation(); 1935 setShouldDoFullPaintInvalidation();
1936 } 1936 }
1937 1937
1938 void LayoutObject::styleWillChange(StyleDifference diff, const ComputedStyle& ne wStyle) 1938 void LayoutObject::styleWillChange(StyleDifference diff, const ComputedStyle& ne wStyle)
1939 { 1939 {
1940 if (m_style) { 1940 if (m_style) {
1941 // If our z-index changes value or our visibility changes, 1941 // If our z-index changes value or our visibility changes,
1942 // we need to dirty our stacking context's z-order list. 1942 // we need to dirty our stacking context's z-order list.
1943 bool visibilityChanged = m_style->visibility() != newStyle.visibility() 1943 bool visibilityChanged = m_style->visibility() != newStyle.visibility()
1944 || m_style->zIndex() != newStyle.zIndex() 1944 || m_style->zIndex() != newStyle.zIndex()
1945 || m_style->hasAutoZIndex() != newStyle.hasAutoZIndex(); 1945 || m_style->isStackingContext() != newStyle.isStackingContext();
1946 if (visibilityChanged) { 1946 if (visibilityChanged) {
1947 document().setAnnotatedRegionsDirty(true); 1947 document().setAnnotatedRegionsDirty(true);
1948 if (AXObjectCache* cache = document().existingAXObjectCache()) 1948 if (AXObjectCache* cache = document().existingAXObjectCache())
1949 cache->childrenChanged(parent()); 1949 cache->childrenChanged(parent());
1950 } 1950 }
1951 1951
1952 // Keep layer hierarchy visibility bits up to date if visibility changes . 1952 // Keep layer hierarchy visibility bits up to date if visibility changes .
1953 if (m_style->visibility() != newStyle.visibility()) { 1953 if (m_style->visibility() != newStyle.visibility()) {
1954 // We might not have an enclosing layer yet because we might not be in the tree. 1954 // We might not have an enclosing layer yet because we might not be in the tree.
1955 if (PaintLayer* layer = enclosingLayer()) 1955 if (PaintLayer* layer = enclosingLayer())
(...skipping 1690 matching lines...) Expand 10 before | Expand all | Expand 10 after
3646 const blink::LayoutObject* root = object1; 3646 const blink::LayoutObject* root = object1;
3647 while (root->parent()) 3647 while (root->parent())
3648 root = root->parent(); 3648 root = root->parent();
3649 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3649 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3650 } else { 3650 } else {
3651 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3651 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3652 } 3652 }
3653 } 3653 }
3654 3654
3655 #endif 3655 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698