Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 } 144 }
145 145
146 void LayoutBoxModelObject::styleWillChange(StyleDifference diff, const ComputedS tyle& newStyle) 146 void LayoutBoxModelObject::styleWillChange(StyleDifference diff, const ComputedS tyle& newStyle)
147 { 147 {
148 // This object's layer may cease to be a stacking context, in which case the paint 148 // This object's layer may cease to be a stacking context, in which case the paint
149 // invalidation container of the children may change. Thus we need to invali date paint 149 // invalidation container of the children may change. Thus we need to invali date paint
150 // eagerly for all such children. 150 // eagerly for all such children.
151 if (hasLayer() 151 if (hasLayer()
152 && enclosingLayer()->stackingNode() 152 && enclosingLayer()->stackingNode()
153 && enclosingLayer()->stackingNode()->isStackingContext() 153 && enclosingLayer()->stackingNode()->isStackingContext()
154 && newStyle.hasAutoZIndex()) { 154 && !newStyle.isStackingContext()) {
155 // The following disablers are valid because we need to invalidate based on the current 155 // The following disablers are valid because we need to invalidate based on the current
156 // status. 156 // status.
157 DisableCompositingQueryAsserts compositingDisabler; 157 DisableCompositingQueryAsserts compositingDisabler;
158 DisablePaintInvalidationStateAsserts paintDisabler; 158 DisablePaintInvalidationStateAsserts paintDisabler;
159 invalidatePaintIncludingNonCompositingDescendants(); 159 invalidatePaintIncludingNonCompositingDescendants();
160 } 160 }
161 161
162 FloatStateForStyleChange::setWasFloating(this, isFloating()); 162 FloatStateForStyleChange::setWasFloating(this, isFloating());
163 163
164 if (const ComputedStyle* oldStyle = style()) { 164 if (const ComputedStyle* oldStyle = style()) {
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 if (rootElementStyle->hasBackground()) 1113 if (rootElementStyle->hasBackground())
1114 return false; 1114 return false;
1115 1115
1116 if (node() != document().firstBodyElement()) 1116 if (node() != document().firstBodyElement())
1117 return false; 1117 return false;
1118 1118
1119 return true; 1119 return true;
1120 } 1120 }
1121 1121
1122 } // namespace blink 1122 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698