Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 { 676 {
677 const LocalFrame* frame = document.frame(); 677 const LocalFrame* frame = document.frame();
678 678
679 RefPtr<ComputedStyle> documentStyle = ComputedStyle::create(); 679 RefPtr<ComputedStyle> documentStyle = ComputedStyle::create();
680 documentStyle->setRTLOrdering(document.visuallyOrdered() ? VisualOrder : Log icalOrder); 680 documentStyle->setRTLOrdering(document.visuallyOrdered() ? VisualOrder : Log icalOrder);
681 documentStyle->setZoom(frame && !document.printing() ? frame->pageZoomFactor () : 1); 681 documentStyle->setZoom(frame && !document.printing() ? frame->pageZoomFactor () : 1);
682 FontDescription documentFontDescription = documentStyle->getFontDescription( ); 682 FontDescription documentFontDescription = documentStyle->getFontDescription( );
683 documentFontDescription.setLocale(document.contentLanguage()); 683 documentFontDescription.setLocale(document.contentLanguage());
684 documentStyle->setFontDescription(documentFontDescription); 684 documentStyle->setFontDescription(documentFontDescription);
685 documentStyle->setZIndex(0); 685 documentStyle->setZIndex(0);
686 documentStyle->setIsStackingContext(true);
686 documentStyle->setUserModify(document.inDesignMode() ? READ_WRITE : READ_ONL Y); 687 documentStyle->setUserModify(document.inDesignMode() ? READ_WRITE : READ_ONL Y);
687 // These are designed to match the user-agent stylesheet values for the docu ment element 688 // These are designed to match the user-agent stylesheet values for the docu ment element
688 // so that the common case doesn't need to create a new ComputedStyle in 689 // so that the common case doesn't need to create a new ComputedStyle in
689 // Document::inheritHtmlAndBodyElementStyles. 690 // Document::inheritHtmlAndBodyElementStyles.
690 documentStyle->setDisplay(BLOCK); 691 documentStyle->setDisplay(BLOCK);
691 documentStyle->setPosition(AbsolutePosition); 692 documentStyle->setPosition(AbsolutePosition);
692 693
693 document.setupFontBuilder(*documentStyle); 694 document.setupFontBuilder(*documentStyle);
694 695
695 return documentStyle.release(); 696 return documentStyle.release();
(...skipping 1038 matching lines...) Expand 10 before | Expand all | Expand 10 after
1734 visitor->trace(m_siblingRuleSet); 1735 visitor->trace(m_siblingRuleSet);
1735 visitor->trace(m_uncommonAttributeRuleSet); 1736 visitor->trace(m_uncommonAttributeRuleSet);
1736 visitor->trace(m_watchedSelectorsRules); 1737 visitor->trace(m_watchedSelectorsRules);
1737 visitor->trace(m_treeBoundaryCrossingScopes); 1738 visitor->trace(m_treeBoundaryCrossingScopes);
1738 visitor->trace(m_styleSharingLists); 1739 visitor->trace(m_styleSharingLists);
1739 visitor->trace(m_pendingStyleSheets); 1740 visitor->trace(m_pendingStyleSheets);
1740 visitor->trace(m_document); 1741 visitor->trace(m_document);
1741 } 1742 }
1742 1743
1743 } // namespace blink 1744 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698