Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update old z-index stacking context test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1993 matching lines...) Expand 10 before | Expand all | Expand 10 after
2004 setShouldDoFullPaintInvalidation(); 2004 setShouldDoFullPaintInvalidation();
2005 } 2005 }
2006 2006
2007 void LayoutObject::styleWillChange(StyleDifference diff, const ComputedStyle& ne wStyle) 2007 void LayoutObject::styleWillChange(StyleDifference diff, const ComputedStyle& ne wStyle)
2008 { 2008 {
2009 if (m_style) { 2009 if (m_style) {
2010 // If our z-index changes value or our visibility changes, 2010 // If our z-index changes value or our visibility changes,
2011 // we need to dirty our stacking context's z-order list. 2011 // we need to dirty our stacking context's z-order list.
2012 bool visibilityChanged = m_style->visibility() != newStyle.visibility() 2012 bool visibilityChanged = m_style->visibility() != newStyle.visibility()
2013 || m_style->zIndex() != newStyle.zIndex() 2013 || m_style->zIndex() != newStyle.zIndex()
2014 || m_style->hasAutoZIndex() != newStyle.hasAutoZIndex(); 2014 || m_style->isStackingContext() != newStyle.isStackingContext();
2015 if (visibilityChanged) { 2015 if (visibilityChanged) {
2016 document().setAnnotatedRegionsDirty(true); 2016 document().setAnnotatedRegionsDirty(true);
2017 if (AXObjectCache* cache = document().existingAXObjectCache()) 2017 if (AXObjectCache* cache = document().existingAXObjectCache())
2018 cache->childrenChanged(parent()); 2018 cache->childrenChanged(parent());
2019 } 2019 }
2020 2020
2021 // Keep layer hierarchy visibility bits up to date if visibility changes . 2021 // Keep layer hierarchy visibility bits up to date if visibility changes .
2022 if (m_style->visibility() != newStyle.visibility()) { 2022 if (m_style->visibility() != newStyle.visibility()) {
2023 // We might not have an enclosing layer yet because we might not be in the tree. 2023 // We might not have an enclosing layer yet because we might not be in the tree.
2024 if (PaintLayer* layer = enclosingLayer()) 2024 if (PaintLayer* layer = enclosingLayer())
(...skipping 1683 matching lines...) Expand 10 before | Expand all | Expand 10 after
3708 const blink::LayoutObject* root = object1; 3708 const blink::LayoutObject* root = object1;
3709 while (root->parent()) 3709 while (root->parent())
3710 root = root->parent(); 3710 root = root->parent();
3711 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3711 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3712 } else { 3712 } else {
3713 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3713 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3714 } 3714 }
3715 } 3715 }
3716 3716
3717 #endif 3717 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698