Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update old z-index stacking context test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 } 142 }
143 143
144 void LayoutBoxModelObject::styleWillChange(StyleDifference diff, const ComputedS tyle& newStyle) 144 void LayoutBoxModelObject::styleWillChange(StyleDifference diff, const ComputedS tyle& newStyle)
145 { 145 {
146 // This object's layer may cease to be a stacking context, in which case the paint 146 // This object's layer may cease to be a stacking context, in which case the paint
147 // invalidation container of the children may change. Thus we need to invali date paint 147 // invalidation container of the children may change. Thus we need to invali date paint
148 // eagerly for all such children. 148 // eagerly for all such children.
149 if (hasLayer() 149 if (hasLayer()
150 && enclosingLayer()->stackingNode() 150 && enclosingLayer()->stackingNode()
151 && enclosingLayer()->stackingNode()->isStackingContext() 151 && enclosingLayer()->stackingNode()->isStackingContext()
152 && newStyle.hasAutoZIndex()) { 152 && !newStyle.isStackingContext()) {
153 // The following disablers are valid because we need to invalidate based on the current 153 // The following disablers are valid because we need to invalidate based on the current
154 // status. 154 // status.
155 DisableCompositingQueryAsserts compositingDisabler; 155 DisableCompositingQueryAsserts compositingDisabler;
156 DisablePaintInvalidationStateAsserts paintDisabler; 156 DisablePaintInvalidationStateAsserts paintDisabler;
157 invalidatePaintIncludingNonCompositingDescendants(); 157 invalidatePaintIncludingNonCompositingDescendants();
158 } 158 }
159 159
160 FloatStateForStyleChange::setWasFloating(this, isFloating()); 160 FloatStateForStyleChange::setWasFloating(this, isFloating());
161 161
162 if (const ComputedStyle* oldStyle = style()) { 162 if (const ComputedStyle* oldStyle = style()) {
(...skipping 963 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 if (rootElementStyle->hasBackground()) 1126 if (rootElementStyle->hasBackground())
1127 return false; 1127 return false;
1128 1128
1129 if (node() != document().firstBodyElement()) 1129 if (node() != document().firstBodyElement())
1130 return false; 1130 return false;
1131 1131
1132 return true; 1132 return true;
1133 } 1133 }
1134 1134
1135 } // namespace blink 1135 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698