Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2047273004: Add bounds check in scope lookup (issue 26633) (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 6 months ago (2016-06-08 15:17:38 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-06-08 16:01:02 UTC) #3
Brian Wilkerson
4 years, 6 months ago (2016-06-08 16:02:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f772c64cfec6444feed94992cc77087c7f0b0640 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698