Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2047263002:
Change ahem.js logic to make tests unflaky (Closed)
|
Created:
4 years, 6 months ago by Takashi Toyoshima Modified:
4 years, 6 months ago Reviewers:
Kunihiko Sakamoto CC:
yosin_UTC9, blink-reviews, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange ahem.js logic to make tests unflaky
BUG=392046, 618179
Committed: https://crrev.com/1c77630ff59a8207fc60242dba9f455203353d2f
Cr-Commit-Position: refs/heads/master@{#398802}
Patch Set 1 #Patch Set 2 : drop stale comment #Patch Set 3 : ArrayBuffer version #
Total comments: 2
Patch Set 4 : comment #
Total comments: 1
Messages
Total messages: 21 (8 generated)
Description was changed from ========== Change ahem.js logic to make tests unflaky BUG=392046, 618179 ========== to ========== Change ahem.js logic to make tests unflaky BUG=392046, 618179 ==========
toyoshim@chromium.org changed reviewers: + ksakamoto@chromium.org
Here is the CL we discussed. Now try is running, and we still need to wait what happens here. But FYI.
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047263002/20001
ok, Sakamoto-san, can you take a look?
lgtm if bots are happy
oops, they looks unhappy actually :(
The CQ bit was unchecked by toyoshim@chromium.org
Some tests do not wait for onload event, but just start checking font metrics by JavaScript. This is because they are originally designed for system fonts that do not need to wait for anything. Let me try another crazy idea, using ArrayBuffer as a FontFace source.
PTAL since the js was changed drastically.
lgtm Thanks! Now Ahem should be loaded synchronously. https://codereview.chromium.org/2047263002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/resources/ahem.js (right): https://codereview.chromium.org/2047263002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/resources/ahem.js:4: var ahem = new Uint8Array([ Can you add a comment saying that this is generated from Ahem.ttf?
https://codereview.chromium.org/2047263002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/resources/ahem.js (right): https://codereview.chromium.org/2047263002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/resources/ahem.js:4: var ahem = new Uint8Array([ On 2016/06/09 03:11:34, Kunihiko Sakamoto wrote: > Can you add a comment saying that this is generated from Ahem.ttf? Done.
The CQ bit was checked by toyoshim@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ksakamoto@chromium.org Link to the patchset: https://codereview.chromium.org/2047263002/#ps60001 (title: "comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047263002/60001
Thanks for quick and amazing work! https://codereview.chromium.org/2047263002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/resources/ahem.js (right): https://codereview.chromium.org/2047263002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/resources/ahem.js:6: var ahem = new Uint8Array([ Wow! Another option is using atob(), but using Uint8Array is faster!
Message was sent while issue was closed.
Description was changed from ========== Change ahem.js logic to make tests unflaky BUG=392046, 618179 ========== to ========== Change ahem.js logic to make tests unflaky BUG=392046, 618179 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Change ahem.js logic to make tests unflaky BUG=392046, 618179 ========== to ========== Change ahem.js logic to make tests unflaky BUG=392046, 618179 Committed: https://crrev.com/1c77630ff59a8207fc60242dba9f455203353d2f Cr-Commit-Position: refs/heads/master@{#398802} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/1c77630ff59a8207fc60242dba9f455203353d2f Cr-Commit-Position: refs/heads/master@{#398802} |
