Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1645)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: Use PRIORITY_PREFERENCE instead of PREFERENCE sync Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index f16361737f09855b8c60492354361cddbffb109f..0d7c7714ec3930ae963e8b53a40f0f0751a85bed 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -51,15 +51,20 @@ class PermissionUmaUtil {
const GURL& embedding_origin,
Profile* profile);
static void PermissionGranted(content::PermissionType permission,
- const GURL& requesting_origin);
+ const GURL& requesting_origin,
+ Profile* profile);
static void PermissionDenied(content::PermissionType permission,
- const GURL& requesting_origin);
+ const GURL& requesting_origin,
+ Profile* profile);
static void PermissionDismissed(content::PermissionType permission,
- const GURL& requesting_origin);
+ const GURL& requesting_origin,
+ Profile* profile);
static void PermissionIgnored(content::PermissionType permission,
- const GURL& requesting_origin);
+ const GURL& requesting_origin,
+ Profile* profile);
static void PermissionRevoked(content::PermissionType permission,
- const GURL& revoked_origin);
+ const GURL& revoked_origin,
+ Profile* profile);
// UMA specifically for when permission prompts are shown. This should be
// roughly equivalent to the metrics above, however it is
@@ -86,7 +91,16 @@ class PermissionUmaUtil {
const std::vector<PermissionBubbleRequest*>& requests);
private:
+ friend class PermissionUmaUtilTest;
+
DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);
Lei Zhang 2016/07/14 09:34:58 DISALLOW macros should always be last.
+
+ static bool IsOptedIntoPermissionActionReporting(Profile* profile);
+
+ static void RecordPermissionAction(content::PermissionType permission,
+ PermissionAction action,
+ const GURL& requesting_origin,
+ Profile* profile);
};
#endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_UMA_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698