Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4510)

Unified Diff: chrome/browser/permissions/permission_uma_util_unittest.cc

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: Remove comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util_unittest.cc
diff --git a/chrome/browser/permissions/permission_uma_util_unittest.cc b/chrome/browser/permissions/permission_uma_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ab291bcf21783565af4fc681c64925a1af9c9450
--- /dev/null
+++ b/chrome/browser/permissions/permission_uma_util_unittest.cc
@@ -0,0 +1,128 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/permissions/permission_uma_util.h"
+
+#include "base/command_line.h"
+#include "chrome/browser/signin/fake_signin_manager_builder.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/browser_sync/browser/profile_sync_service.h"
+#include "components/browser_sync/common/browser_sync_switches.h"
+#include "components/prefs/pref_service.h"
+#include "components/signin/core/browser/fake_signin_manager.h"
+#include "components/sync_driver/glue/sync_backend_host_mock.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "sync/internal_api/public/base/model_type.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+const char* kTestingGaiaId = "gaia_id";
+const char* kTestingUsername = "fake_username";
+} // namespace
+
+class PermissionUmaUtilTest : public testing::Test {
+ protected:
+ PermissionUmaUtilTest() : profile_(new TestingProfile()) {}
+
+ static bool IsOptedInPermissionActionReporting(Profile* profile) {
+ return PermissionUmaUtil::IsOptedInPermissionActionReporting(profile);
+ }
+
+ void SetUp() override {
+ profile_.reset(new TestingProfile());
+ base::CommandLine::Reset();
+ base::CommandLine::Init(0, NULL);
+ }
+
+ void FakeSignIn() {
+ SigninManagerBase* signin_manager = static_cast<FakeSigninManager*>(
+ SigninManagerFactory::GetForProfile(profile()));
+ signin_manager->SetAuthenticatedAccountInfo(kTestingGaiaId,
+ kTestingUsername);
+ // Attach a sync backend to the profile sync service.
+ GetProfileSyncService()->backend_.reset(
+ new browser_sync::SyncBackendHostMock());
+ GetProfileSyncService()->backend_initialized_ = true;
+ }
+
+ void SetSafeBrowsing(bool enabled) {
+ PrefService* preferences = profile_->GetPrefs();
+ preferences->SetBoolean(prefs::kSafeBrowsingEnabled, enabled);
+ }
+
+ ProfileSyncService* GetProfileSyncService() {
+ return ProfileSyncServiceFactory::GetForProfile(profile());
+ }
+
+ Profile* profile() { return profile_.get(); }
+
+ private:
+ content::TestBrowserThreadBundle thread_bundle_;
+ std::unique_ptr<Profile> profile_;
+};
+
+TEST_F(PermissionUmaUtilTest, IsOptedInPermissionActionReportingSignInCheck) {
kcarattini 2016/07/06 01:44:34 Can you add comments before each test fixture sayi
stefanocs 2016/07/06 04:25:45 Done.
+ SetSafeBrowsing(true);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnablePermissionActionReporting);
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+
+ FakeSignIn();
+ EXPECT_FALSE(
+ IsOptedInPermissionActionReporting(profile()->GetOffTheRecordProfile()));
+ EXPECT_TRUE(IsOptedInPermissionActionReporting(profile()));
+}
+
+TEST_F(PermissionUmaUtilTest, IsOptedInPermissionActionReportingFlagCheck) {
+ SetSafeBrowsing(true);
+ FakeSignIn();
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kDisablePermissionActionReporting);
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+}
+
+TEST_F(PermissionUmaUtilTest,
+ IsOptedInPermissionActionReportingSafeBrowsingCheck) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnablePermissionActionReporting);
+ FakeSignIn();
+ SetSafeBrowsing(false);
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+}
+
+TEST_F(PermissionUmaUtilTest,
+ IsOptedInPermissionActionReportingProfileSyncServiceCheck) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnablePermissionActionReporting);
+ SetSafeBrowsing(true);
+ FakeSignIn();
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(switches::kDisableSync);
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+}
+
+TEST_F(PermissionUmaUtilTest,
+ IsOptedInPermissionActionReportingSyncPreferenceCheck) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnablePermissionActionReporting);
+ SetSafeBrowsing(true);
+ FakeSignIn();
+
+ GetProfileSyncService()->OnUserChoseDatatypes(
+ false, syncer::ModelTypeSet(syncer::PROXY_TABS));
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+
+ GetProfileSyncService()->OnUserChoseDatatypes(
+ false, syncer::ModelTypeSet(syncer::PREFERENCES));
+ EXPECT_FALSE(IsOptedInPermissionActionReporting(profile()));
+
+ GetProfileSyncService()->OnUserChoseDatatypes(
+ false, syncer::ModelTypeSet(syncer::PROXY_TABS, syncer::PREFERENCES));
+ EXPECT_TRUE(IsOptedInPermissionActionReporting(profile()));
+}

Powered by Google App Engine
This is Rietveld 408576698