Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context.cc

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: Modify sync preference check test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_util.cc ('k') | chrome/browser/safe_browsing/ping_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_permission_context.cc
diff --git a/chrome/browser/push_messaging/push_messaging_permission_context.cc b/chrome/browser/push_messaging/push_messaging_permission_context.cc
index f5591c26faeba9bab26117e7fa51b77fbf57bd05..8760f79aca87a4fac5cf19a9f4f126bf628510df 100644
--- a/chrome/browser/push_messaging/push_messaging_permission_context.cc
+++ b/chrome/browser/push_messaging/push_messaging_permission_context.cc
@@ -117,7 +117,8 @@ void PushMessagingPermissionContext::DecidePushPermission(
if (push_content_setting == CONTENT_SETTING_BLOCK) {
DVLOG(1) << "Push permission was explicitly blocked.";
- PermissionUmaUtil::PermissionDenied(permission_type(), requesting_origin);
+ PermissionUmaUtil::PermissionDenied(permission_type(), requesting_origin,
kcarattini 2016/06/24 03:48:57 As we discussed, can you double check and then add
raymes 2016/06/27 04:36:17 Stefano and I are looking into this. It's a bit ha
kcarattini 2016/06/30 02:53:11 Ok, has there been a bug filed for this? I didn't
+ profile_);
NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
true /* persist */, CONTENT_SETTING_BLOCK);
return;
@@ -130,7 +131,8 @@ void PushMessagingPermissionContext::DecidePushPermission(
return;
}
- PermissionUmaUtil::PermissionGranted(permission_type(), requesting_origin);
+ PermissionUmaUtil::PermissionGranted(permission_type(), requesting_origin,
+ profile_);
NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
true /* persist */, CONTENT_SETTING_ALLOW);
}
« no previous file with comments | « chrome/browser/permissions/permission_util.cc ('k') | chrome/browser/safe_browsing/ping_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698