chrome/browser/permissions/permission_context_base.cc - Issue 2047253002: Add hooks to permission layer for permission action reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation

Patch Set: Refactor tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_bubble_request_impl.cc ('k') | chrome/browser/permissions/permission_infobar_delegate.cc » ('j') | chrome/browser/permissions/permission_uma_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_context_base.cc

diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc

index 74691a47252c1499c26da3613e256769238fe092..e2fece8f26933393659f2ced7067d017675bd1b8 100644

--- a/chrome/browser/permissions/permission_context_base.cc

+++ b/chrome/browser/permissions/permission_context_base.cc

@@ -214,12 +214,15 @@ void PermissionContextBase::PermissionDecided(

DCHECK(content_setting == CONTENT_SETTING_ALLOW ||

content_setting == CONTENT_SETTING_BLOCK);

if (content_setting == CONTENT_SETTING_ALLOW)

- PermissionUmaUtil::PermissionGranted(permission_type_, requesting_origin);

+ PermissionUmaUtil::PermissionGranted(permission_type_, requesting_origin,

+ profile_);

else

- PermissionUmaUtil::PermissionDenied(permission_type_, requesting_origin);

+ PermissionUmaUtil::PermissionDenied(permission_type_, requesting_origin,

+ profile_);

} else {

DCHECK_EQ(content_setting, CONTENT_SETTING_DEFAULT);

- PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_origin);

+ PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_origin,

+ profile_);

}

#endif