components/browser_sync/browser/profile_sync_service.h - Issue 2047253002: Add hooks to permission layer for permission action reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service.h

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation

Patch Set: resolve nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/browser_sync/browser/profile_sync_service.h

diff --git a/components/browser_sync/browser/profile_sync_service.h b/components/browser_sync/browser/profile_sync_service.h

index 3fecc3197fa8b306fb396ec8b051385d7a41aae3..52dd0378ccc1facb7c0b2391e6ad5f6902131bcc 100644

--- a/components/browser_sync/browser/profile_sync_service.h

+++ b/components/browser_sync/browser/profile_sync_service.h

@@ -633,6 +633,8 @@ class ProfileSyncService : public sync_driver::SyncService,

syncer::PassphraseRequiredReason passphrase_required_reason_;

private:

+ friend class PermissionUmaUtilTest;

raymes 2016/06/22 02:11:13 nit: move this down to where the other "friend" de

stefanocs 2016/06/22 04:28:12 Done.

enum UnrecoverableErrorReason {

ERROR_REASON_UNSET,

ERROR_REASON_SYNCER,

« chrome/browser/permissions/permission_uma_util_unittest.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »