Add hooks to permission layer for permission action reporting

chrome/browser/safe_browsing/ping_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_PING_MANAGER_H_
 #define CHROME_BROWSER_SAFE_BROWSING_PING_MANAGER_H_
 
 // A class that reports safebrowsing statistics to Google's SafeBrowsing
 // servers.
 #include <memory>
@@ skipping 13 matching lines @@
 class ErrorReporter;
 }
 
 namespace net {
 class SSLInfo;
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace safe_browsing {
 
+class PermissionReporter;
+
 class SafeBrowsingPingManager : public net::URLFetcherDelegate {
  public:
   ~SafeBrowsingPingManager() override;
 
   // Create an instance of the safe browsing ping manager.
   static SafeBrowsingPingManager* Create(
       net::URLRequestContextGetter* request_context_getter,
       const SafeBrowsingProtocolConfig& config);
 
   // net::URLFetcherDelegate interface.
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Report to Google when a SafeBrowsing warning is shown to the user.
   // |hit_report.threat_type| should be one of the types known by
   // SafeBrowsingtHitUrl.
   void ReportSafeBrowsingHit(const safe_browsing::HitReport& hit_report);
 
   // Users can opt-in on the SafeBrowsing interstitial to send detailed
   // threat reports. |report| is the serialized report.
   void ReportThreatDetails(const std::string& report);
 
   // Users can opt-in on the SSL interstitial to send reports of invalid
   // certificate chains.
   void ReportInvalidCertificateChain(const std::string& serialized_report);
 
   void SetCertificateErrorReporterForTesting(
       std::unique_ptr<certificate_reporting::ErrorReporter>
           certificate_error_reporter);
 
+  PermissionReporter* permission_reporter();

[raymes, 2016/06/14 02:47:11]

Do you think we should have a Send function here, rather than exposing the
PermissionReporter? I don't feel strongly except that it would be more aligned
with the other functions in this class. In that case the flag check could live
in this class too.

[stefanocs, 2016/06/14 03:37:37]

Should we remove the ReportPermissionAction function from PermissionUmaUtil and
let the Send function be called by the RecordPermissionAction then?

[raymes, 2016/06/14 03:58:16]

That seems good since the function will be so small

+
  private:
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest,
                            TestSafeBrowsingHitUrl);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest, TestThreatDetailsUrl);
 
   typedef std::set<const net::URLFetcher*> Reports;
 
   // Constructs a SafeBrowsingPingManager that issues network requests
   // using |request_context_getter|.
   SafeBrowsingPingManager(
@@ skipping 20 matching lines @@
   std::string url_prefix_;
 
   // Track outstanding SafeBrowsing report fetchers for clean up.
   // We add both "hit" and "detail" fetchers in this set.
   Reports safebrowsing_reports_;
 
   // Sends reports of invalid SSL certificate chains.
   std::unique_ptr<certificate_reporting::ErrorReporter>
       certificate_error_reporter_;
 
+  // Sends reports of permission actions.
+  std::unique_ptr<PermissionReporter> permission_reporter_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingPingManager);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_PING_MANAGER_H_