Add hooks to permission layer for permission action reporting

chrome/browser/permissions/permission_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include <utility>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/permissions/permission_manager.h"
 #include "chrome/browser/permissions/permission_util.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/safe_browsing/permission_reporter.h"
+#include "chrome/browser/safe_browsing/ping_manager.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
 #include "components/rappor/rappor_service.h"
 #include "components/rappor/rappor_utils.h"
 #include "content/public/browser/permission_type.h"
 #include "content/public/common/origin_util.h"
 #include "url/gurl.h"
 
 // UMA keys need to be statically initialized so plain function would not
 // work. Use macros instead.
 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \
@@ skipping 215 matching lines @@
         base::HistogramBase::kUmaTargetedHistogramFlag);
     histogram->Add(static_cast<int>(embedding_permission_status));
   } else {
     UMA_HISTOGRAM_ENUMERATION(
         "Permissions.Requested.SameOrigin",
         static_cast<base::HistogramBase::Sample>(permission),
         static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
   }
 }
 
+void ReportPermissionAction(const GURL& origin,
+                            PermissionType permission,
+                            PermissionAction action) {
+  // TODO(stefanocs): Send reports to opted-in users only.
+  safe_browsing::PermissionReporter* permission_reporter =

[kcarattini, 2016/06/13 21:21:09]

You need to guard this with the flag you added in your first cl.

[stefanocs, 2016/06/14 01:06:18]

Is this the right way to do this?

+      g_browser_process->safe_browsing_service()
+          ->ping_manager()
+          ->permission_reporter();
+  permission_reporter->SendReport(origin, permission, action);
+}
+
 }  // anonymous namespace
 
 const char PermissionUmaUtil::kPermissionsPromptShown[] =
     "Permissions.Prompt.Shown";
 const char PermissionUmaUtil::kPermissionsPromptAccepted[] =
     "Permissions.Prompt.Accepted";
 const char PermissionUmaUtil::kPermissionsPromptDenied[] =
     "Permissions.Prompt.Denied";
 const char PermissionUmaUtil::kPermissionsPromptRequestsPerPrompt[] =
     "Permissions.Prompt.RequestsPerPrompt";
@@ skipping 10 matching lines @@
                                             const GURL& requesting_origin,
                                             const GURL& embedding_origin,
                                             Profile* profile) {
   RecordPermissionRequest(permission, requesting_origin, embedding_origin,
                           profile);
 }
 
 void PermissionUmaUtil::PermissionGranted(PermissionType permission,
                                           const GURL& requesting_origin) {
   RecordPermissionAction(permission, GRANTED, requesting_origin);
+  ReportPermissionAction(requesting_origin, permission, GRANTED);

[kcarattini, 2016/06/13 21:21:09]

Can RecordPermissionAction just call ReportPermissionAction instead? Or are
there times when we wouldn't want it called?

[stefanocs, 2016/06/14 01:06:18]

Yes, but that means we have to add more params to the function signature when we
have added SourceUI and RequestTrigger. Do you think it is ok to pass these two
params to RecordPermissionAction only so that it can passed to
ReportPermissionAction?

[raymes, 2016/06/14 02:47:11]

I think that's ok :)

[stefanocs, 2016/06/14 03:37:37]

Done.

 }
 
 void PermissionUmaUtil::PermissionDenied(PermissionType permission,
                                          const GURL& requesting_origin) {
   RecordPermissionAction(permission, DENIED, requesting_origin);
+  ReportPermissionAction(requesting_origin, permission, DENIED);
 }
 
 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
                                             const GURL& requesting_origin) {
   RecordPermissionAction(permission, DISMISSED, requesting_origin);
+  ReportPermissionAction(requesting_origin, permission, DISMISSED);
 }
 
 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
                                           const GURL& requesting_origin) {
   RecordPermissionAction(permission, IGNORED, requesting_origin);
+  ReportPermissionAction(requesting_origin, permission, IGNORED);
 }
 
 void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
                                           const GURL& revoked_origin) {
   // TODO(tsergeant): Expand metrics definitions for revocation to include all
   // permissions.
   if (permission == PermissionType::NOTIFICATIONS ||
       permission == PermissionType::GEOLOCATION ||
       permission == PermissionType::AUDIO_CAPTURE ||
       permission == PermissionType::VIDEO_CAPTURE) {
     RecordPermissionAction(permission, REVOKED, revoked_origin);
+    ReportPermissionAction(revoked_origin, permission, REVOKED);
   }
 }
 
 void PermissionUmaUtil::PermissionPromptShown(
     const std::vector<PermissionBubbleRequest*>& requests) {
   DCHECK(!requests.empty());
 
   PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;
   if (requests.size() == 1)
     permission_prompt_type = requests[0]->GetPermissionBubbleType();
@@ skipping 46 matching lines @@
 }
 
 void PermissionUmaUtil::PermissionPromptDenied(
     const std::vector<PermissionBubbleRequest*>& requests) {
   DCHECK(!requests.empty());
   DCHECK(requests.size() == 1);
 
   PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied,
                              requests[0]->GetPermissionBubbleType());
 }