Add hooks to permission layer for permission action reporting

chrome/browser/safe_browsing/ping_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_PING_MANAGER_H_
 #define CHROME_BROWSER_SAFE_BROWSING_PING_MANAGER_H_
 
 // A class that reports safebrowsing statistics to Google's SafeBrowsing
 // servers.
 #include <memory>
 #include <set>
 #include <string>
 #include <vector>
 
+#include "base/command_line.h"

[raymes, 2016/06/16 01:10:22]

nit: is this needed here?

[stefanocs, 2016/06/16 01:52:20]

Done.

 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
+#include "chrome/browser/permissions/permission_uma_util.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/safe_browsing/protocol_manager_helper.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "components/browser_sync/browser/profile_sync_service.h"
+#include "components/prefs/pref_service.h"

[raymes, 2016/06/16 01:10:22]

Same with most of these?

[stefanocs, 2016/06/16 01:52:19]

Done.

 #include "components/safe_browsing_db/hit_report.h"
 #include "components/safe_browsing_db/util.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "url/gurl.h"
 
 namespace certificate_reporting {
 class ErrorReporter;
 }
 
 namespace net {
 class SSLInfo;
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace safe_browsing {
 
+class PermissionReporter;
+
 class SafeBrowsingPingManager : public net::URLFetcherDelegate {
  public:
   ~SafeBrowsingPingManager() override;
 
   // Create an instance of the safe browsing ping manager.
   static SafeBrowsingPingManager* Create(
       net::URLRequestContextGetter* request_context_getter,
       const SafeBrowsingProtocolConfig& config);
 
   // net::URLFetcherDelegate interface.
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Report to Google when a SafeBrowsing warning is shown to the user.
   // |hit_report.threat_type| should be one of the types known by
   // SafeBrowsingtHitUrl.
   void ReportSafeBrowsingHit(const safe_browsing::HitReport& hit_report);
 
   // Users can opt-in on the SafeBrowsing interstitial to send detailed
   // threat reports. |report| is the serialized report.
   void ReportThreatDetails(const std::string& report);
 
   // Users can opt-in on the SSL interstitial to send reports of invalid
   // certificate chains.
   void ReportInvalidCertificateChain(const std::string& serialized_report);
 
   void SetCertificateErrorReporterForTesting(
       std::unique_ptr<certificate_reporting::ErrorReporter>
           certificate_error_reporter);
 
+  // Report permission action to SafeBrowsing servers.
+  void ReportPermissionAction(const GURL& origin,
+                              content::PermissionType permission,

[raymes, 2016/06/16 01:10:22]

nit: we should include permission_type.h

[stefanocs, 2016/06/16 01:52:20]

Do we still need to include that even though it was already included in
permission_uma_util.h?

[raymes, 2016/06/20 02:46:33]

Yes - you either need to forward declare or #include every symbol.

+                              PermissionAction action);
+
  private:
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest,
                            TestSafeBrowsingHitUrl);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest, TestThreatDetailsUrl);
 
   typedef std::set<const net::URLFetcher*> Reports;
 
   // Constructs a SafeBrowsingPingManager that issues network requests
   // using |request_context_getter|.
   SafeBrowsingPingManager(
@@ skipping 20 matching lines @@
   std::string url_prefix_;
 
   // Track outstanding SafeBrowsing report fetchers for clean up.
   // We add both "hit" and "detail" fetchers in this set.
   Reports safebrowsing_reports_;
 
   // Sends reports of invalid SSL certificate chains.
   std::unique_ptr<certificate_reporting::ErrorReporter>
       certificate_error_reporter_;
 
+  // Sends reports of permission actions.
+  std::unique_ptr<PermissionReporter> permission_reporter_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingPingManager);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_PING_MANAGER_H_